Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6519] - $_SERVER variables were not overrided with JRequest::setVar().

? Success

User tests: Successful: Unsuccessful:

avatar desplega
desplega
20 Mar 2015

$_SERVER variables were not overrided with JRequest::setVar().

avatar desplega desplega - open - 20 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2015
Labels Added: ?
avatar desplega desplega - close - 20 Mar 2015
avatar desplega desplega - change - 20 Mar 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-03-20 18:44:12
avatar desplega desplega - close - 20 Mar 2015
avatar desplega desplega - reopen - 20 Mar 2015
avatar desplega desplega - change - 20 Mar 2015
Status Closed ⇒ New
avatar desplega desplega - reopen - 20 Mar 2015
avatar desplega desplega - close - 20 Mar 2015
avatar desplega desplega - change - 20 Mar 2015
Status New ⇒ Closed
Closed_Date 2015-03-20 18:44:12 ⇒ 2015-03-20 18:44:44
avatar desplega desplega - close - 20 Mar 2015
avatar desplega desplega - reopen - 20 Mar 2015
avatar desplega desplega - change - 20 Mar 2015
Status Closed ⇒ New
avatar desplega desplega - reopen - 20 Mar 2015
avatar vdespa
vdespa - comment - 22 Mar 2015

Can you please edit your PR and add testing instructions. Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6519.
avatar vdespa vdespa - change - 22 Mar 2015
Status New ⇒ Information Required
avatar zero-24 zero-24 - change - 22 Mar 2015
Category ⇒ Libraries
avatar joomdonation
joomdonation - comment - 23 Mar 2015

I think this PR fixes a clear typing mistake in the code. I think It is hard to provide testing instructions in this case, so we will need a PLT to review and merge it. Maybe @wilsonge can help with this one?

avatar fastslack
fastslack - comment - 23 Mar 2015

@desplega did you checked using JInput?

avatar desplega
desplega - comment - 23 Mar 2015

You can test with the following snipped:
JRequest::setVar('PHP_TEST', 'Test', 'server');
$test = JRequest::getVar('PHP_TEST', '', 'server');
if ($test == 'Test')
echo 'OK';
else
echo 'Fail';

avatar rdeutz rdeutz - change - 23 Mar 2015
Status Information Required ⇒ Confirmed
avatar rdeutz
rdeutz - comment - 23 Mar 2015

Obviously a typo mistake, Patch looking good to me. Crossing fingers that nobody used that wrong behaviour in a component ;-)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6519.
avatar vdespa vdespa - change - 23 Mar 2015
Status Confirmed ⇒ Pending
avatar rdeutz rdeutz - test_item - 23 Mar 2015 - Tested successfully
avatar dam-man
dam-man - comment - 10 Apr 2015

@test

Patch is fixing the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6519.

avatar dam-man dam-man - test_item - 10 Apr 2015 - Tested successfully
avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 10 Apr 2015

RTC Thanks for testing!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6519.

avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Apr 2015
Title
…
Update request.php
$_SERVER variables were not overrided with JRequest::setVar().
avatar zero-24 zero-24 - close - 10 Apr 2015
avatar wilsonge wilsonge - change - 10 Apr 2015
Status Ready to Commit ⇒ Closed
Closed_Date 2015-03-20 18:44:44 ⇒ 2015-04-10 13:50:38
avatar wilsonge wilsonge - close - 10 Apr 2015
avatar wilsonge wilsonge - reference | - 10 Apr 15
avatar wilsonge wilsonge - merge - 10 Apr 2015
avatar wilsonge wilsonge - close - 10 Apr 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment