?

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
20 Mar 2015
  1. Removed the long awkward if -> elseif -> elseif -> else structure from JCacheControllerCallback::get

  2. Added private methods to normalise the callback.

  3. Removed "else" where I felt comfortable doing so.

avatar Mathewlenning Mathewlenning - open - 20 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 21 Mar 2015
Milestone Added:
avatar zero-24 zero-24 - change - 22 Mar 2015
Category Libraries
avatar Mathewlenning
Mathewlenning - comment - 22 Mar 2015

I don't think there is anything I can do to resolve this one. I added the additional check from the last merge to this class, but it isn't working.

avatar dgt41
dgt41 - comment - 22 Mar 2015

Try to rebase the repo to the latest staging. I am using tower (gui) so all i do is make a pull from latest staging with the option to rebase enabled, i guess something similar should be the command on the terminal. But I don’t know if this is the recommended solution here

avatar Mathewlenning
Mathewlenning - comment - 24 Mar 2015

@dgt41 Thanks. I'm using PHPStorm and I do remember a rebase option. Let me try and see if it works.

avatar Mathewlenning
Mathewlenning - comment - 24 Mar 2015

I pulled from staging, but but it doesn't seem to be working.

avatar Mathewlenning Mathewlenning - change - 28 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-28 01:51:24
Closed_By Mathewlenning
avatar Mathewlenning Mathewlenning - close - 28 Sep 2015
avatar Mathewlenning Mathewlenning - close - 28 Sep 2015
avatar Mathewlenning Mathewlenning - head_ref_deleted - 28 Sep 2015

Add a Comment

Login with GitHub to post a comment