Looks good from a code review generally :)

Also looks good to me. We won't add this in the 3.4.1 but we can merge it for the 3.4.2 version. Thank you @Mathewlenning!

Sounds good =^D Hopefully I'll have a few more ready by then.

Sincerely,
Mathew Lenning

Babel-University.com http://babel-university.com/
406-626-3251
LinkedIn Profile http://linkedin.com/pub/mathew-lenning/30/268/52b/

On Thu, Mar 19, 2015 at 10:07 PM, Viktor Vogel notifications@github.com
wrote:

Also looks good to me. We won't add this in the 3.4.1 but we can merge it
for the 3.4.2 version. Thank you @Mathewlenning
https://github.com/Mathewlenning!

—
Reply to this email directly or view it on GitHub
#6497 (comment).

I brought this up on the mailinglist a few weeks ago: I think this is a good example for a refactoring that belongs int a minor release and not in a patch release. Likewise with the other refactoring that you did.

@hannes

You'll hear no complaints from me. 3.4.x or 3.5.0 either way works. And if we are going full SemVer then 3.5 would be the best place for it. Imagine how much we could clean the core up by then.

Sincerely,
Mathew Lenning

Babel-university.com

P.S. This message was sent via iPhone, so please forgive any errors

On Mar 20, 2015, at 6:22 PM, Hannes Papenberg notifications@github.com wrote:

I brought this up on the mailinglist a few weeks ago: I think this is a good example for a refactoring that belongs int a minor release and not in a patch release. Likewise with the other refactoring that you did.

\
Reply to this email directly or view it on GitHub.

@Mathewlenning @Hackwar Okay, good point. I'll move the milestone to 3.5. Thank you for your input!

I was just wondering what is the RTC tag for?

Ready to commit

Thanks =^D Still learning the lingo

Sincerely,
Mathew Lenning

Babel-University.com http://babel-university.com/
406-626-3251
LinkedIn Profile http://linkedin.com/pub/mathew-lenning/30/268/52b/

On Fri, Mar 20, 2015 at 11:05 PM, Michael Babker notifications@github.com
wrote:

Ready to commit

—
Reply to this email directly or view it on GitHub
#6497 (comment).

Merged into 3.5 dev branch. Thanks Mathew!