? Success

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
18 Mar 2015

Isolated JError into temporary method and separated old extraction logic from streaming logic.

I'm not sure where this is used, but most likely in the installer.
I did a find usage with PHPStorm, but the only results I got where from the unit tests.

So if anyone knows where it is used could you let me know.

avatar Mathewlenning Mathewlenning - open - 18 Mar 2015
avatar Mathewlenning
Mathewlenning - comment - 18 Mar 2015

For some reason this didn't get tagged and TCI wasn't initiated. Is Bzip2 on the exclude list?

avatar wilsonge
wilsonge - comment - 18 Mar 2015

Nothing should be on the exclude list. I'll try and work out what's going on!

avatar Mathewlenning
Mathewlenning - comment - 18 Mar 2015

It started up after I pushed a few style fixes. I'm guessing it was just a hiccup in TCI

avatar Kubik-Rubik
Kubik-Rubik - comment - 19 Mar 2015

Looks good to me. We won't add this in the 3.4.1 but after another successful test we can merge it for the 3.4.2 version. Thank you @Mathewlenning!

avatar Kubik-Rubik Kubik-Rubik - change - 19 Mar 2015
Milestone Added:
avatar vdespa vdespa - change - 20 Mar 2015
Status New Pending
Build staging
avatar Kubik-Rubik Kubik-Rubik - change - 20 Mar 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 20 Mar 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 22 Mar 2015
Category Libraries
avatar wilsonge wilsonge - change - 6 Nov 2015
Milestone Removed:
avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you @Mathewlenning!

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 09:32:25
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 8 May 2016

Add a Comment

Login with GitHub to post a comment