? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Mar 2015

Only way to check this is check the unit tests continue to function as expected.

Largely this is just making the checks more self-explanatory using the built in assertFalse etc commands rather than assert that.

It creates a new Installer instance instead of using getInstance.

I refactored the testGetInstance to first check the correct type was returned and then calling it again gives the same object

Finally I added two new tests to test basic functionality to parseLanguages and parseFiles

avatar wilsonge wilsonge - open - 18 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Mar 2015
The description was changed
avatar wilsonge wilsonge - change - 18 Mar 2015
Title
Start refactoring the JInstallerTests
Start work on the JInstallerTests
avatar Hackwar
Hackwar - comment - 18 Mar 2015

Looks good.

avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Mar 2015

Thank you @wilsonge!

avatar Kubik-Rubik Kubik-Rubik - change - 18 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-18 13:22:57
avatar Kubik-Rubik Kubik-Rubik - close - 18 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - reference | - 18 Mar 15
avatar Kubik-Rubik Kubik-Rubik - merge - 18 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - close - 18 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - change - 18 Mar 2015
Milestone Added:
avatar wilsonge wilsonge - head_ref_deleted - 18 Mar 2015

Add a Comment

Login with GitHub to post a comment