? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
17 Mar 2015

As per the doc block I've typecast the result to be a boolean as it was returning the string 0 on false and 1 on true for the enabled state of the plugin (as these are the values stored in the database). Currently you get true and false in the frontend and 0 and 1 in the backend.

Testing

In the backend ensure that the modal views when you are selecting a single item in the menu show everything properly

Replaces #6443

avatar wilsonge wilsonge - open - 17 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 22 May 2015
Category Unit Tests
avatar mbabker
mbabker - comment - 19 Jul 2015

Think you could redo this with mock data injection in a similar manner to what we did with the Framework application package's tests so we can start cutting some of the dependencies on global manipulation?

avatar wilsonge
wilsonge - comment - 19 Jul 2015

Nope - but I'll try anyhow :D

avatar mbabker
mbabker - comment - 19 Jul 2015

Copy/paste is your friend :wink:

avatar wilsonge
wilsonge - comment - 19 Jul 2015

Class "JApplicationSite" is declared "final" and cannot be mocked.

avatar wilsonge
wilsonge - comment - 19 Jul 2015

I've pushed the code to mock the admin application tho

avatar roland-d roland-d - reference | a995db6 - 8 May 16
avatar roland-d roland-d - merge - 8 May 2016
avatar roland-d roland-d - close - 8 May 2016
avatar roland-d roland-d - change - 8 May 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 16:37:36
Closed_By roland-d
avatar roland-d roland-d - change - 8 May 2016
Milestone Added:
avatar roland-d
roland-d - comment - 8 May 2016

Merged on review.

avatar wilsonge wilsonge - head_ref_deleted - 8 May 2016

Add a Comment

Login with GitHub to post a comment