User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | Accessibility |
What is the reason for not using the <h3>
in the modals?
For chosen: Best is to have them fix it on their side and then update to that version once it's fixed.
Best not to tamper with the 3rd party js files.
Chosen: harvesthq/chosen#2270
H tags should cascade gracefully. Try users list view: there is an h1 for the title and if there is user note the modal title will be an h3 tag. But h3 should follow after an h2...
@nonumber Peter the problem with chosen isn’t so simple. Joomla is using chosen v0.14 but chosen is now at v1.4.1. The problem is that with the release of version 1.0 they change all the selectors from chzn-
to chosen-
which obviously breaks backwards compatibility. Your PR is against the latest staging but here we still use something outdated, so even if that gets accepted we still can’t use that as it is incompatible with joomla’s b/c policy. Is kinda dead end situation with that code, that’s the reason I suggested to move on to select2 or bootstrap select...
Going by the explanation of the Chosen guys at harvesthq/chosen#2270 (comment) I think we'll just let this be for what it is.
I don’t see much interest on this, so I am gonna close it.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-12 19:08:03 |
Closed_By | ⇒ | dgt41 |
Labels |
Added:
?
|
The
<b class="caret"></b>
should not be converted tostrong
, but tospan
. I have already done that in #6467