User tests: Successful: Unsuccessful:
This patch is similar to #6445, but for the Language Manager.
To test, install Persian fa-IR or Arabic (ar-AA)
Go to
administrator/index.php?option=com_languages
before patch:
after patch
test that all works fine when switching to en-GB
Labels |
Added:
?
|
This should be only added if a RTL language is loaded and not as default. I would prefer to have this addition in the model and not in the template file. Thanks!
I missed it in #6445 - the comment is valid there as well but really a
minor thing and not worth spending too much time on
I guess its always a questionable decision. Do you display LTR text in an
RTL manner when you are in RTL mode. You will probably find 50/50 answers
so just ignore it for now.
On 17 March 2015 at 10:46, Viktor Vogel notifications@github.com wrote:
This should be only added if a RTL language is loaded and not as default.
I would prefer to have this addition in the model and not in the template
file. Thanks!—
Reply to this email directly or view it on GitHub
#6473 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@Kubik-Rubik
The result is the same if RTL language is loaded or not (that is why I suggested to test with en-GB).
Nevertheless, I changed to add the conditional and the correct code in the model instead of the template.
Thank you @infograf768!
Same solution as in #6449, I will merge this PR.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-17 11:21:08 |
Milestone |
Added: |
Its not "perfect" as the text is still LTR it should read (en-GB) English
etc as you can see with the arabic
(Still better than current situaiton though)
On 17 March 2015 at 10:36, infograf768 notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/