User tests: Successful: Unsuccessful:
Added same changes to 2.5.x as in commit af510cc for the joomla 3 master branch as per suggestion.
This is still in reference to Peter's original pull request: #589
This pull request does the same thing for the 2.5.x branch. I tested it and it seems to work fine (with the special test plugin), but I encourage someone else to test it too.
See: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29968
I suggest we get it merged as is since it matches the master/3 branch. Then we can consider the next steps.
-Jonathan
OK. It works very well. Let's do it. :)
Please create a tracker in 2.5 Issue tracker in joomlacode and cross reference here
Updated the fork for the pull request for the recent code style updates.
Peter van Westen tested this. See the tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=11410&tracker_item_id=29968
@ITPrism Todor would you please test this patch again to verify that it still works properly on Joomla 2.5.x (using the test plugin from @phproberto: https://github.com/phproberto/plg_content_27699).
Peter (@nonumber) has tested this. I think if you can verify that this test still works, we may get it accepted into Joomla 2.5.x.
Thanks
-Jonathan
Tested and set as ready to commit.
Thanks @jmcameron !
I've just tested it with plg_content_27699 and other plugins.
It works perfect!
Thank you @jmcameron and @phproberto!
Merged into 2.5.x by @infograf768, commit 5bb4e65. Thanks!
@infograf768 when I tried to close this PR on the 2.5.x branch, it complained that it has unmerged commits. When I look at the base repo, the changes in the PR are in committed (which you did in commit 5bb4e65). And there are no file differences. What is the proper way to close this PR out?
None of the commits from the PR are actually merged into the CMS. When JM and I commit items, we apply the proper patch from the source (usually a GitHub branch), do one final test of the change, glance over the code for any code style errors as tested with our CI server, and add an entry to our CHANGELOG file prior to pushing the change to the repo. So, while the PR may say there are unmerged commits, as you can see, your change has been implemented.
Thanks Michael!
I tested it and it works very well.
One more thing. It would be good if we replace "$this->params" with "$item->params" when we triggering "onContentPrepare". Thus, we will receive the parameters of the item, as in other cases.
What do you think about variable "$results =," which is before the event "onContentPrepare"?
That event does not return result and we don't use that variable. So, it can be removed.