[#6467] - [Accessibility] Replaced i with span tags
- Closed
- 22 May 2015
- Medium
- Build: staging
- Easy Test
- # 6467
- Diff
- nonumber:a11y.i2span
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR takes care of all the icon <i> tags in the Joomla core outputs, replacing them with <span> tags.
So <i class="icon-..."></i> becomes <span class="icon-..."></span>.
The <i> tags are not good from an accessibility point of view.
Replacing them with spans has no visual impact.
Testing the control panel via http://achecker.ca/checker:
Before:
After:
To test, make sure all icons are displaying properly and that scripts that control icons still work ok.
Some scripts that have been tweaked to work with the spans:
- the update notification script (controlling the messages on the control panel left bottom)
- the tree menu script controlling the folding icons in the menu item selection (in modules for example)
This can impact 3rd party extensions that might have javascript or css specifically written to expect <i> tags, like:
i.icon-home { ... }
Those would have to be changed to keep working.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Title |
|
||||||
| Easy | No | ⇒ | Yes | ||||
| Category | ⇒ | Administration UI/UX |
brianteeman
- | Title |
|
||||||
| Category | Administration UI/UX | ⇒ | Accessibility Administration UI/UX |
| Title |
|
||||||
| Title |
|
||||||
Before testing I changed J!Tracker Application at issues.joomla.org/joomla-cms/6467.
Not sure what you mean. Why is test unsuccessful?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6467.
Sorry, my message seems to be broken. The patch didn't replace an i-tag I added to the login-form before testing.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6467.
That's not what this PR does. It fixes the tags in Joomla's own output files. It doesn't dynamically replace you custom HTML.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6467.
Sorry! I'll check again later.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6467.
I have checked this and it looks good. I can't find any issues. Can we get this moved to the master branch?
I like it :) Can we merge in staging please for the conflicts
Merge conflicts fixed.
Just wanted to test this so we can move it forward but I get the following errors trying to apply the patch:
error: patch failed: administrator/components/com_categories/models/fields/modal/category.php:148
error: administrator/components/com_categories/models/fields/modal/category.php: patch does not apply
error: patch failed: administrator/components/com_contact/models/fields/modal/contact.php:143
error: administrator/components/com_contact/models/fields/modal/contact.php: patch does not apply
error: patch failed: administrator/components/com_content/models/fields/modal/article.php:138
error: administrator/components/com_content/models/fields/modal/article.php: patch does not apply
error: patch failed: administrator/components/com_newsfeeds/models/fields/modal/newsfeed.php:144
error: administrator/components/com_newsfeeds/models/fields/modal/newsfeed.php: patch does not apply
warning: administrator/components/com_redirect/views/links/tmpl/default.php has type 100644, expected 100755
Can you check please?
Should be ok now.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-22 21:15:59 |
| Closed_By | ⇒ | roland-d |
| Milestone |
Added: |
||
johanjanssens
-
PS: This PR does not touch the FOF files.