[#6451] - generatecss.php generates .min.css
- Closed
- 18 May 2015
- Medium
- Build: staging
- # 6451
- Diff
- nonumber:less.compiler2
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In this PR:
- Made the generatecss.php also generate .min.css files
- Tweaked the generatecss.php to improve output
- Re-compiled the css files
- Added the .min.css files
- Made the templates/files use the change the.min.css files (except when in DEBUG mode)
Changes I made to the generatecss.php:
- Made the function style values have spaces after commas, like
rgb(2555, 255, 255, 1) - Expands # rgb colours to the full 6 digit format, so
#fc9becomes#ffcc99
joomla-cms-bot
- | Labels |
Added:
?
|
||
PS: because of the licensing issue with the oyejorge/less.php, we have to stick with the leafo/lessphp, even though development has stopped on it.
So unfortunately this means the (non-minified) css files don't have the comments in them.
leafo/lessphp does a bad job of adding the comments from less files to the css files (all are placed at top of file). I haven't been able to quick-fix that.
According to the changelog on http://leafo.net/lessphp/changelog.html
version 0.4.0 – August 09 2013
Warning: this release has some breaking changes. If you the old selector expression syntax (eg. Bootstrap 2.3) then it’s recommended to use 0.3.9.
I think that was the reason why we never updated beyond 0.3.9.
Not sure what the impact really is.
Output via latest (v0.5.0) seems fine.
Latest commits to v0.5.0 are from Apr 27, 2014
@nonumber I'm sorry but we will not be accepting PR's that make changes to the code imported by composer. If you feel these changes are essential then we can make them to the Joomla wrapper code for less (https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/less/less.php). But to be honest in these cases I'd just leave it. You're not gaining anything for the pain you're going to self-inflict trying to update the less library in the future.
The leafo less library is no longer under development, so it won't ever need to get updated.
So why use composer for that library anyway? Might as well fork the whole thing and do with it what we want.
It's no longer under development but the last change was done less than 4 months ago. So we might still update it yet - it's to soon to say.
I'll revert it back to the old version and do some after-process fixes in the generatecss.php.
keeping it at 0.5 is fine. it's just the changes from there you need to revert. But thanks :)
v0.5.0 was not fine. Found issues with it (not inheriting overwritten variables)
zero-24
- | Category | ⇒ | External Library Repository |
All should be good for testing...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6451.
Ok, redid some stuff as it was completely out of sync due to css commits.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-18 11:34:57 |
| Closed_By | ⇒ | nonumber |
@nonumber Can you also make the changes for minified to
administrator/templates/isis/component.php
administrator/templates/isis/login.php
templates/protostar/component.php
templates/protostar/error.php