Feeling Lucky
?
[#6405] - Setting mbstring.internal_encoding in PHP 5.6 is deprecated
- Closed
- 12 Mar 2015
- Medium
- Build: staging
- # 6405
- Diff
- Digital-Peak:patch-5
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In PHP 5.6 the internal encoding is deprecated which can result in an error message. The setting default charset should be used instead. Documentation can be found here http://php.net/manual/en/mbstring.configuration.php#ini.mbstring.internal-encoding
joomla-cms-bot
- | Labels |
Added:
?
|
||
jhasenbach
- comment
- 12 Mar 2015
Works for me. Good Job.
laoneo
- comment
- 12 Mar 2015
Done.
@jhasenbach can you please add the comment there that it works on your site too. Thank you.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-12 14:55:36 |
Could you send a PR for this to the upstream vendor repo (https://github.com/joomla-framework/string) please? Files within the libraries/vendor folder are external resources to the CMS repo.
Since all of those settings are deprecated, I'd also suggest just wrapping the whole block in a version_compare check; if PHP 5.6 just set
default_charsetotherwise try and check the other existing conditions.