? Success

User tests: Successful: Unsuccessful:

avatar zero-24 zero-24 - open - 12 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 12 Mar 2015

Can you paste the content from joomlacode here - as it will be closing soon
the link will break - thanks

On 12 March 2015 at 13:26, zero-24 notifications@github.com wrote:

Redo: #4024 #4024
See:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34008&start=0

and http://www.w3.org/TR/html-markup/input.file.html

You can view, comment on, or merge this pull request online at:

#6403
Commit Summary

  • w3c validation error input type file and value

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6403.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 12 Mar 2015

How to reproduce the problem and/or test the patch::

include an item in an xml form file that uses type="file" then generate the input tag using $form->getInput('fieldname'). The resultant <input> tag includes the 'value' attribute which is invalid for an input type of 'file' and causes an HTML compliance error.

title

HTML compliance error for input tags with type='file'

details

<input> tags with type='file' generated by JForm include a 'value' attribute which is invalid for this input type and causes an HTML compliance error.
I fixed the problem by removing the 'value=""' string from line 137 of libraries/joomla/form/fields/file.php
avatar n9iels
n9iels - comment - 12 Mar 2015

@test: confirmed, the patch works and remove the value propety


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6403.
avatar n9iels n9iels - test_item - 12 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 12 Mar 2015
Status New Pending
avatar zero-24 zero-24 - change - 12 Mar 2015
Category Code style
avatar compojoom
compojoom - comment - 14 Mar 2015

@test: confirmed, the patch works and remove the value propety


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6403.
avatar compojoom compojoom - test_item - 14 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Setting RTC thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6403.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 14 Mar 2015
avatar mbabker mbabker - change - 14 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 14:52:12
avatar mbabker mbabker - close - 14 Mar 2015
avatar mbabker mbabker - reference | - 14 Mar 15
avatar mbabker mbabker - merge - 14 Mar 2015
avatar mbabker mbabker - close - 14 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment