? Success

User tests: Successful: Unsuccessful:

avatar smehrbrodt
smehrbrodt
11 Mar 2015

This allows to change the default list limit to "All" which means, that there is no limit.

Testing

Go to "Global Configuration" and verify that there is an option "All" for list limit:
unlimited

Result: When you change that limit to "All", "All" should be selected by default e.g. in the article view.

avatar smehrbrodt smehrbrodt - open - 11 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 11 Mar 2015

Good addition! I like it :smile:
@test: Works fine for me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar n9iels n9iels - test_item - 11 Mar 2015 - Tested successfully
avatar bertmert
bertmert - comment - 11 Mar 2015

Yes, PR works, BUT
Just to be mentioned. There are views in frontend that use this option as default for limit box (e.g. contact single catgeory).
It should be established an additional option in com_config like list_limit_frontend to avoid frontend crashes.

avatar smehrbrodt
smehrbrodt - comment - 11 Mar 2015

@bertmert Does this change break any extension? In my tests, it doesn't. Even in the frontend the new setting works.

avatar Bakual
Bakual - comment - 11 Mar 2015

There should be established an additional option like list_limit_frontend to avoid frontend crashes.

I wouldn't add a new option. The parameter already is meant to be used in frontend.
"All" rarely is a good selection, that's why it currently isn't in the list. But we could of course add it, it's just one a user never should use :smile:

avatar smehrbrodt
smehrbrodt - comment - 11 Mar 2015

"All" rarely is a good selection, that's why it currently isn't in the list. But we could of course add it, it's just one a user never should use :smile:

Well, I would use it. One extension I use implemented their own pagination using Ajax, which doesn't work with my template override. So I just want it to display all items at once. That would be possible with this change.

avatar mbabker
mbabker - comment - 11 Mar 2015

This option is a GLOBAL behavior. So it changes the limits site wide when adjusted. I agree that "All" isn't a good option in this context. It's an option that should be overridden at the component level when components really need or want to provide that option at their level. For component developers, it's a matter of setting the list.limit value in the model state before the pagination object gets created.

avatar bertmert
bertmert - comment - 11 Mar 2015

"Does this change break any extension?"
Core components com_search (results), com_contacts (single category), com_tags(?) don't have an own option for frontend like "display_num" like in com_content (category list).

Thus these views try to show ALL results/items when a user opens this views in frontend the first time. Earliest as a second step user can set custom value in limit box that's written in his/her session for next visit. If no limit box is displayed user has no chance to get rid of waiting for all results.

Now, it could be discussed if "normal" backend user is aware that this setting is also for some frontend views. I remember that I needed some time then ;-))

@Bakual Yes, you're right. Additional global option for frontend would be to much.

avatar smehrbrodt
smehrbrodt - comment - 12 Mar 2015

I agree that "All" isn't a good option in this context.

What if someone wants his lists to be longer than 100 items by default? Could we at least add some greater values like 500 and 1000?

avatar smehrbrodt
smehrbrodt - comment - 12 Mar 2015

I reverted the part of the feed limit (it makes no sense there).
Hopefully we can agree on some solution for list limit.

avatar Bakual
Bakual - comment - 12 Mar 2015

What if someone wants his lists to be longer than 100 items by default? Could we at least add some greater values like 500 and 1000?

Are we talking about 500 or 1000 articles per page? That doesn't sound like something anyone ever wants to do. Even 100 is far more than is reasonable.
Or are we talking about a specific extension where that would make sense. Then what Michael said is true, it should be provided on a per extension basis and you shoudl contact the extension developer to see if he can get that fixed.

avatar smehrbrodt
smehrbrodt - comment - 12 Mar 2015

That doesn't sound like something anyone ever wants to do. Even 100 is far more than is reasonable.

Well, in my scenario it does make sense. Why would you not let the user decide that? I'm not talking about changing the default, just allowing greater values.

avatar Bakual
Bakual - comment - 12 Mar 2015

You have a list in frontend with 100+ articles from com_content?

avatar smehrbrodt
smehrbrodt - comment - 12 Mar 2015

No, from RSEvents. It's a list with archived events. Their pagination doesn't work for me.

avatar zero-24 zero-24 - change - 12 Mar 2015
Category UI/UX
avatar brianteeman
brianteeman - comment - 13 Mar 2015

So isn't that a bug with RSEvents then?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar christianhent christianhent - test_item - 14 Mar 2015 - Tested successfully
avatar designbengel designbengel - test_item - 14 Mar 2015 - Tested unsuccessfully
avatar designbengel
designbengel - comment - 14 Mar 2015

Option "All" is added to Default List Limit but not to Default Feed Limit.
The new list limit applies only after beginning a a new session (Logout/Login).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar smohila
smohila - comment - 14 Mar 2015

Same here: Only after re-login the "all" limit is set as default in e.g. article view.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar smohila smohila - test_item - 14 Mar 2015 - Tested successfully
avatar smohila smohila - test_item - 14 Mar 2015 - Tested successfully
avatar m-b-o m-b-o - test_item - 14 Mar 2015 - Tested successfully
avatar FrankyDE
FrankyDE - comment - 14 Mar 2015

Tested Patch suchessfully

avatar brianteeman
brianteeman - comment - 14 Mar 2015

Thanks for testing - I am setting this to Needs Review based on @bakual comments so that CMS maintainers can make a decision IF this is really something that should be applied


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending Needs Review
avatar bertmert
bertmert - comment - 14 Mar 2015

For me option ALL is still nonsense as long some frontend views use this setting as default. AND as long as

"Core components com_search (results), com_contacts (single category), com_tags(?) don't have an own option for frontend like "display_num"..."

avatar MyDadisDead
MyDadisDead - comment - 14 Mar 2015

The test added All to the list, but did not make it default in the articles.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar debbing
debbing - comment - 14 Mar 2015

tested successfully.
setting "all" the first time, it didnĀ“t work. Log Out, Log in. Now ist works fine.

avatar abecaroma
abecaroma - comment - 14 Mar 2015

it works fine
this feature was already available in Joomla 2.5 used it quite often


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar abecaroma abecaroma - test_item - 14 Mar 2015 - Tested successfully
avatar bullet64
bullet64 - comment - 15 Mar 2015

Tested patch successfully.

avatar nonumber
nonumber - comment - 16 Mar 2015

We've been down this path before and ran into issues.
Setting the limit to unlimited is not a good idea. It will make extensions crash, also core.
Has this been tested on setups with 50.000 articles?

An unlimited approach would only make sense if results are loaded via ajax in chunks, like Google Images does for instance. But loading 100+ items in a list view is asking for trouble.

Also, many extensions will trigger events for each item returned (like the category blog page). That means that certain plugins will also be triggered 100+ times!

avatar smehrbrodt
smehrbrodt - comment - 16 Mar 2015

Can we then at least add some greater values to choose from? Maybe 500 or 1000? That at least should not break the site, but would be enough for most cases.

avatar brianteeman
brianteeman - comment - 16 Mar 2015

As you have stated your issue is specific to one extension and you should take that up with that extension.

Multiple people have stated very good reasons why a global setting of ALL (and other high values) are bad ideas.

I am closing this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6396.
avatar brianteeman brianteeman - change - 16 Mar 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-03-16 15:43:03
Closed_By brianteeman
avatar brianteeman brianteeman - close - 16 Mar 2015

Add a Comment

Login with GitHub to post a comment