? Success
Pull Request for # 6350

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
6 Mar 2015

Commit 2d8bf0f introduced a bug described in #6350 - this PR resolves this.


The problem

When Global Configuration Cache is enabled, plugins are stuck in the state recorded at the time of cache creation, meaning that a plugin that's been enabled will stay enabled until cache expires. Manually disabling or enabling a plugin should also refresh the cache so that this operation completes successfuly.

How to reproduce

This is a little tricky to reproduce but here are the steps

Prerequisites

  • Go to Extensions > Plugin Manager and make sure System - Debug is published.
  • Go to Global Configuration and make sure Cache Handler is set to File and Cache is set to OFF - Caching disabled.

Testing

  • Go to Global Configuration > System and set Debug System to Yes. Save your current configuration - you should now see the debug output at the bottom.
  • Go to Extensions > Plugin Manager and unpublish the System - Debug plugin. Debug output no longer shows. Publish it again. Debug output shows as expected.
  • Go to Global Configuration > System and set Cache to ON - Conservative caching. Save your current configuration - debug output is still at the bottom.
  • Go to Extensions > Plugin Manager and unpublish the System - Debug plugin. Debug output still shows - this means that the plugin still runs even though it should not.

The solution

During my tests I've found out that cache for com_plugins is stored in the cache folder as well as in administrator/cache. My solution would be to clean both of these by adjusting cleanCache() in the administrator/components/com_plugins/models/plugin.php model, but I'm open to other suggestions. Personally I'd like that we'd keep caching for system objects such as plugins in only one place (let's say on the administrator side).

avatar OctavianC OctavianC - open - 6 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Mar 2015
Category Administration Cache Components
avatar zero-24 zero-24 - change - 6 Mar 2015
The description was changed
Rel_Number 6350
Relation Type Pull Request for
avatar bertmert
bertmert - comment - 8 Mar 2015

@test Success
Tested also with twofactorauth plugins where tabulators in user profile aren't removed after deactivating plugins. After patch: fine.

avatar zero-24 zero-24 - alter_testresult - 8 Mar 2015 - bertmert: Tested successfully
avatar brianteeman
brianteeman - comment - 13 Mar 2015

@test worked for me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6353.
avatar brianteeman brianteeman - test_item - 13 Mar 2015 - Tested successfully
avatar brianteeman brianteeman - change - 13 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 13 Mar 2015
Labels Added: ?
avatar zurborg zurborg - test_item - 14 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - close - 15 Mar 2015
avatar phproberto phproberto - change - 15 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-15 07:42:16
avatar phproberto phproberto - close - 15 Mar 2015
avatar phproberto phproberto - close - 15 Mar 2015
avatar phproberto
phproberto - comment - 15 Mar 2015

Merge. Thanks!

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment