Feeling Lucky
?
[#6351] - Set max-height back to 400 px for modals
- Closed
- 8 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6351
- Diff
- dgt41:_bootstrap_modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Modals don’t have a height limit
This was found by @roland-d.
In the PR for moving multilingual status to bootstrap modal a line in the less fie was wrongly changed to none;
This PR brings back the cap to 400px
test
apply patch
open multilingual status and observe the height of the modal (should be 400px)
joomla-cms-bot
- | Labels |
Added:
?
|
||
dgt41
- comment
- 6 Mar 2015
One minor thing though:
With height set to 400px some of the big modals always have scroll bars:
Raising the height to 570 seem to cover most cases
But we can override the default value per case so no real problem!
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration UI/UX |
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 8 Mar 2015
Moving RTC based on testing. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6351.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-08 20:01:25 |
Bakual
- | Milestone |
Added: |
||
@test Success, this brings back the height as expected. Thanks, one more tester.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6351.