[#6335] - Fix - Call to undefined function Composer\Autoload\includeFile()
- Closed
- 17 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 6335
- Diff
- joomlatools:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Joomla 3.4 is extending Composer\Autoload\ClassLoader to make sure JLoader::applyAliasFor($class); is called when a class is being loaded.
Description
The implementation in Joomla 3.4 prevents to use composer in your own extension and requires developers to implement a workaround first.
To resolve this the PR rewrites the implementation and instead of extending Composer\Autoload\ClassLoader it decorates it. This is the advised approach to handle this scenario by the Composer team. For details see following discussion.
Additionally the fix brings the Composer integration in Joomla more inline with Composer itself. The specialised composer_autoload.php file is removed in favour of the autoload.php file generated by Composer.
List of changes
- Remove /libraries/composer_autoload.php use default /libraries/vendor/autoload.php as per composer specification
- Decorate \Composer\Autoload\ClassLoader through JClassLoader
- Unregister default class loader and register decorator during Joomla Cms bootstrapping
Testing instructions
Make sure Joomla still works.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries Repository |
To be merged, the deleted files should be added into:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L339
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@infograf768 Thanks for the headsup. Made it so.
Little suggestion to optimise this process. Deleted files and folder could be added to a JSON file during package build. This can be done by getting the info from Git or by comparing packages. A JSON files could be created by the packager to hold the deleted files and folders.
We moved everything across to JRegistry so things would still work. You should try using JRegistry instead of /Joomla/Registry/Registry in places and check it still works.
@test i have just tryed some external components (e.g. akeeba backup and ARS es well as others) and they work with that patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6335.
Merged in e1cfdc0 - thankyou very much @johanjanssens :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-17 20:49:25 |
| Closed_By | ⇒ | wilsonge |
resolve joomlatools/joomla-fork#2
Hey Johan. Thanks for this. Looks like a great improvement. A few small things. Firstly travis is failing pretty hard with this change. Secondly can you fix the spaces instead of tabs in the files please :)