?
Referenced as Pull Request for: # 6345
avatar jjnxpct
jjnxpct
6 Mar 2015

Steps to reproduce the issue

Put this in the template index.php:
$doc->setMetaData('msapplication-TileColor', '#b4285f');

Expected result

meta name="msapplication-TileColor" content="#b4285f"

Actual result

meta name="msapplication-tilecolor" content="#b4285f"
(No more uppercase characters on the meta name.)

System information (as much as possible)

Joomla 3.4.0

Additional comments

The file libraries/joomla/document/document.php -> public function setMetaData sets the $name to:

$name = strtolower($name);

But I believe the name of the tag I want to include in the template need to have the uppercase characters. Why is this strtolower added here?

avatar jjnxpct jjnxpct - open - 6 Mar 2015
avatar jjnxpct jjnxpct - change - 6 Mar 2015
The description was changed
avatar jjnxpct jjnxpct - change - 6 Mar 2015
The description was changed
avatar jjnxpct jjnxpct - change - 6 Mar 2015
The description was changed
avatar jjnxpct
jjnxpct - comment - 6 Mar 2015

https://msdn.microsoft.com/en-us/library/ie/dn255024%28v=vs.85%29.aspx
"Be aware that preset values are case-sensitive and must be specified using the case shown."


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6330.
avatar brianteeman brianteeman - change - 6 Mar 2015
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 6 Mar 2015

http://www.w3.org/TR/html5/document-metadata.html#attr-meta-name

This states:

Names are case-insensitive, and must be compared in an ASCII case-insensitive manner.

And then goes on in 4.2.5.2 Other metadata names to show several examples of capitalised first letters of Names. (Keyword, Synonyms etc...)

Therefore it should not really matter if Joomla makes them lowercase or not really.. Or should we pander to Microsoft for the sake of removing one line of code...

avatar PhilETaylor PhilETaylor - reference | - 6 Mar 15
avatar PhilETaylor
PhilETaylor - comment - 6 Mar 2015

PR Opened. #6345

avatar zero-24 zero-24 - change - 6 Mar 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-03-06 22:35:10
Closed_By zero-24
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-03-06 22:35:10
avatar joomla-cms-bot joomla-cms-bot - close - 6 Mar 2015
avatar joomla-cms-bot
joomla-cms-bot - comment - 6 Mar 2015

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/6330

avatar zero-24
zero-24 - comment - 6 Mar 2015

Closing as we have a PR thanks @PhilETaylor #6345


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6330.
avatar joomla-cms-bot joomla-cms-bot - close - 6 Mar 2015

Add a Comment

Login with GitHub to post a comment