[#633] - Load additional language files only optional to avoid overwriting existing keys
- Closed
- 6 May 2014
- Medium
- Build: master
- # 633
- Diff
- bembelimen:patch-3
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
Thanks for coding this, bembelimen!
While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues
Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.
Thanks in advance and thanks again for coding this, bembelimen!
Tested successfully. This indeed prevents language files to be loaded and subsequently overwriting existing keys when a language file has already been loaded for that key.
And considering that this PR is 11 months old, we should finally kill Joomlacode and switch over to github. Its ridiculous to keeping this up.
With the words of Cato the Elder: Ceterum censeo Joomlacode esse delendam (I believe that Joomlacode has to be destroyed. ;-) )
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-06 23:37:47 |
Please create tracker on joomlacode.
Also I suggest using same format as other similar code, i.e
. $lang->load($component, JPATH_BASE, null, false, false)
|| $lang->load($component, JPATH_BASE, $lang->getDefault(), false, false)
|| etc.