Please activate JavaScript in your browser.
?
?
Success
Success
The Travis CI build passed
Details
User tests:
Successful:
Unsuccessful:
This series of Pull Requests improve some basic code styles.
Mostly if/else syntax improvements, focussing on removing else statements which follow returns (or continues in loops).
Also de-nesting of if structures by adding early returns/elses.
Example:
function foobar($foo, $bar)
{
if($foo > $bar)
{
return $foo;
} else {
return $bar;
}
}
Can be changed to:
function foobar($foo, $bar)
{
if($foo > $bar)
{
return $foo;
}
return $bar;
}
PS: This only illustrates the 'issue' with the useless else statements.
Current PRs in this series:
nonumber
-
open
-
4 Mar 2015
joomla-cms-bot
-
change
-
4 Mar 2015
nonumber
-
change
-
7 Mar 2015
Title
Differences
…
Edit Improved syntax: elses after returns/continues [com_cache]
Edit Improved syntax: Reducing use of else statements, adding early return s [com_cache]
nonumber
-
change
-
8 Mar 2015
Title
Differences
…
Edit Improved syntax: Reducing use of else statements, adding early returns [com_cache]
Improved syntax: Reducing use of else statements, adding early returns [com_cache]
nonumber
-
change
-
8 Mar 2015
Title
Differences
…
Improved syntax: Reducing use of else statements, adding early returns [com_cache]
[CODE SYNTAX] Reducing use of else statements, adding early returns [com_cache]
nonumber
-
change
-
8 Mar 2015
Title
Differences
…
[CODE SYNTAX] Reducing use of else statements, adding early returns [com_cache]
[CODE STYLE ] Reducing use of else statements, adding early returns [com_cache]
nonumber
-
change
-
8 Mar 2015
Title
Differences
…
[CODE SYNTAX] Reducing use of else statements, adding early returns [com_cache]
[CODE STYLE ] Reducing use of else statements, adding early returns [com_cache]
brianteeman
-
change
-
23 Jun 2015
nonumber
-
change
-
10 Aug 2015
Status
Pending
⇒
Closed
Closed_Date
0000-00-00 00:00:00
⇒
2015-08-10 18:22:58
Closed_By
⇒
nonumber
nonumber
-
close
-
10 Aug 2015
nonumber
-
close
-
10 Aug 2015
Add a Comment
Login with GitHub to post a comment
If this doesn't find any interest within a week or 2, I'll close this PR and create new PRs with smaller fixes (one fix per PR).