User tests: Successful: Unsuccessful:
This PR applies an upstream bug fix to CodeMirror
see: codemirror/CodeMirror@076afcb
Set Codemirror as default editor.
Either create a new article or edit an existing article.
Type a forward slash ( / ) in the editor window.
A forward slash appears in the editor window
No slash....
Apply patch - set CodeMirror as active editor see if you can type a slash in editor window
Labels |
Added:
?
|
@test confirmed, but the patch doesn't solve the issue for me.
This has already been reported and fixed in the upstream project. This PR is a cherrypick of their own solution as referenced in codemirror/codemirror5@076afcb14e8be6
Ok I have now upgraded CodeMirror to 5.0.0 released 11 days ago in this PR for testing - this includes all upstream bugfixes
Please see #6150
On 3 Mar 2015 17:06, "Phil Taylor" notifications@github.com wrote:
Ok I have now upgraded CodeMirror to 5.0.0 released 11 days ago in this PR
for testing - this includes all upstream bugfixes—
Reply to this email directly or view it on GitHub
#6280 (comment).
I'm not able to test this patch via the Pacht tester component. When I apply I get a white screen. Not sure if this is a problem with my localhost or the patch..
well as we already have a PR for upgrading CodeMirror, maybe this one can just die? :-(
The PR brian mentioned is planned for Joomla! 3.5.0 (am I right?).
Should be nice if you can find a fix for this problem for Joomla! 3.4.1, because it is a very irritating bug. Things like typing a css path are impossible now.
When/If this gets merged is not my call... as is the way, you can spend years on a PR but its up to others if it will even be tested, or checked, or merged, and when - out of my hands...
All I know is that with this PR I can now type slashes and I cannot see any other issues created by the changes proposed.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-03 18:45:57 |
Is this issue in an external library or our implementation of it?
If it is in the codemirror code then we shouldnt be touching it and should
instead just report upstream
On 3 March 2015 at 16:55, Phil Taylor notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/