? Success

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
3 Mar 2015

This PR applies an upstream bug fix to CodeMirror
see: codemirror/CodeMirror@076afcb

Steps to reproduce the issue

Set Codemirror as default editor.
Either create a new article or edit an existing article.
Type a forward slash ( / ) in the editor window.

Expected result

A forward slash appears in the editor window

What happens

No slash....

To test this PR

Apply patch - set CodeMirror as active editor see if you can type a slash in editor window

Closes #6277
Closes #6181

avatar PhilETaylor PhilETaylor - open - 3 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 3 Mar 2015

Is this issue in an external library or our implementation of it?
If it is in the codemirror code then we shouldnt be touching it and should
instead just report upstream

On 3 March 2015 at 16:55, Phil Taylor notifications@github.com wrote:

This PR applies an upstream bug fix to CodeMirror
Steps to reproduce the issue

Set Codemirror as default editor.
Either create a new article or edit an existing article.
Type a forward slash ( / ) in the editor window.
Expected result

A forward slash appears in the editor window
What happens

No slash....
To test this PR

Apply patch - set CodeMirror as active editor see if you can type a slash
in editor window

Closes #6277 #6277

Closes #6181 #6181

You can view, comment on, or merge this pull request online at:

#6280
Commit Summary

  • Fix for Codemirror Cant Type Forward Slash

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6280.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar n9iels
n9iels - comment - 3 Mar 2015

@test confirmed, but the patch doesn't solve the issue for me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6280.
avatar n9iels n9iels - test_item - 3 Mar 2015 - Tested unsuccessfully
avatar PhilETaylor
PhilETaylor - comment - 3 Mar 2015

This has already been reported and fixed in the upstream project. This PR is a cherrypick of their own solution as referenced in codemirror/codemirror5@076afcb14e8be6

avatar PhilETaylor PhilETaylor - change - 3 Mar 2015
The description was changed
avatar PhilETaylor
PhilETaylor - comment - 3 Mar 2015

Ok I have now upgraded CodeMirror to 5.0.0 released 11 days ago in this PR for testing - this includes all upstream bugfixes

avatar brianteeman
brianteeman - comment - 3 Mar 2015

Please see #6150
On 3 Mar 2015 17:06, "Phil Taylor" notifications@github.com wrote:

Ok I have now upgraded CodeMirror to 5.0.0 released 11 days ago in this PR
for testing - this includes all upstream bugfixes


Reply to this email directly or view it on GitHub
#6280 (comment).

avatar PhilETaylor
PhilETaylor - comment - 3 Mar 2015

hmm ok - well after upgrading with this PR I can now type a forward slash

screen shot 2015-03-03 at 17 12 10

avatar n9iels
n9iels - comment - 3 Mar 2015

I'm not able to test this patch via the Pacht tester component. When I apply I get a white screen. Not sure if this is a problem with my localhost or the patch..

avatar PhilETaylor
PhilETaylor - comment - 3 Mar 2015

well as we already have a PR for upgrading CodeMirror, maybe this one can just die? :-(

avatar n9iels
n9iels - comment - 3 Mar 2015

The PR brian mentioned is planned for Joomla! 3.5.0 (am I right?).
Should be nice if you can find a fix for this problem for Joomla! 3.4.1, because it is a very irritating bug. Things like typing a css path are impossible now.

avatar PhilETaylor
PhilETaylor - comment - 3 Mar 2015

When/If this gets merged is not my call... as is the way, you can spend years on a PR but its up to others if it will even be tested, or checked, or merged, and when - out of my hands...

All I know is that with this PR I can now type slashes and I cannot see any other issues created by the changes proposed.

avatar wilsonge
wilsonge - comment - 3 Mar 2015

As we already have a open PR upgrading to Codemirror 5 (#6150) may I suggest we focus efforts there. If you want to test that it would be hugely appreciated :)

avatar wilsonge wilsonge - change - 3 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-03 18:45:57
avatar wilsonge wilsonge - close - 3 Mar 2015

Add a Comment

Login with GitHub to post a comment