Pending

User tests: Successful: Unsuccessful:

avatar shumisha
shumisha
2 Jan 2013

This is a proposal to add an helper class to simplify rendering JLayoutFile layouts, replacing:

$layout = new JLayoutFile($layoutFile, $basePath);
$renderedLayout = $layout->render($displayData);

with:
$renderedHtml = JLayoutHelper::renderFile('id.of.layout.file', $data);

Should be used when the $layout object is only used once when rendering a page. If the same layout object is used several times, being fed various data, then the helper is of no use.

In this PR, JHtmlSidebar has been modified to make use of the helper, so to test the change, one only needs to apply and checks that the output of all backend extensions is unchanged.

Important: bug fix in #621 MUST be applied prior to trying to use this change

avatar shumisha shumisha - open - 2 Jan 2013
avatar nicksavov
nicksavov - comment - 28 Mar 2013

Thanks for coding this, Yannick!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Yannick!

avatar shumisha shumisha - close - 28 Mar 2013
avatar shumisha
shumisha - comment - 28 Mar 2013

Nick, it appears this was included already in 3.1 master, probably by Elin.
I am thus closing this PR

avatar nicksavov
nicksavov - comment - 28 Mar 2013

Great, thanks Yannick!

avatar shumisha shumisha - head_ref_deleted - 3 Nov 2013

Add a Comment

Login with GitHub to post a comment