Hi Nikolai,

I agree the style and readability there could be improved. I would do this in a separate pull request for two reasons:

1. It is unrelated to the issue I was fixing with incomplete class names.

2. There are others, for example, on lines 139 and 183. A PR that changes all of these so that readability is improved, but also consistency is maintained throughout the file.

I will gladly do that tomorrow and put in another PR. Will also look around and see if it is present in any other files within the template. :)

Hi Cristina,
that's perfectly fine with me.

Of course one should try to separate the issues - not mixing code style changes with bug fixes..
But since this is what the current maintainers are practicing, we should take the chance whenever someone is willing to commit something..

Hopefully we will have a "coding style fun and pizza event" or something in the near future since we have such nice coding styles and automated checkers that are able to tell us that there are currently over 50.000 violations.

Cheers ;)

Thanks Nikolai,

You're right, I added a second commit that brought a bit of consistency across the board.

1. Added params variable to index file.
2. Made fluid class statement consistent throughout
3. Fixed the issue with invalid class name output for itemid, layout and task

Made new tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29875

That looks pretty cool :)

The patch works fine but contains some trailing spaces:

I have the patch test ready. Ping me when fixed and I'll post the test and mark the issue as ready to commit :)

Merged at b0ec110