[#6248] - Add bootstrap checkout icon
- Closed
- 7 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6248
- Diff
- n9iels:checkout-icon
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The problem
When an article is checked out by another user, you will see on the front-end a legacy icon without text
Expected result
It should be nice if see a Bootstrap icon, or a legacy icon, with text
How to test this patch
1) Make sure you checkout an article on the font-end by following this steps
2) Create a second user who can edit articles on front-end
3) Open two browsers, for example FireFox and Goolge Chrome
4) Login on the front-end with a user on firefox and edit an article, stay in edit mode!
5) Login on the front-end with a second user on Google Chrome and notice the same dropdown as the screenshot above
6) Applay the patch
7) Notice the following dropdown
8) Go to components/com_content/helpers/icon.php, and edit line 134 to:
public static function edit($article, $params, $attribs = array(), $legacy = true)
9) Refresh Google Chrome, and notice the following dropdown:
Votes
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End UI/UX |
| Easy | No | ⇒ | Yes |
can you explain what you mean by: agline the =
Thanks for testing!
ow, never mind. I understand
Thanks 
One more tester here!
@Erftralle thanks for testing! Yes that's right, I changed that after I submited this PR. Seems a more logic text in my opinion :-)
Seems a more logic text in my opinion
Definetly, I agree.
@n9iels sorry but again Travis is a bad boy 
There is a PR that fix the last error: n9iels#1 / https://travis-ci.org/joomla/joomla-cms/jobs/52659140
As it is no functional change i move this to RTC and this can merged if the CS PR is merged. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6248.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Good catch. If I recall right Joomla 3.3.6 displayed the icon as a non legacy icon. Was hoping that an admin could checkin a article from the frontend. ;-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6248.
@test: Worked fine, thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6248.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-07 04:10:11 |
Merged. Thanks!
| Labels |
Removed:
?
|
||
tested successful and commented on very mirror CS. Good change @n9iels
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6248.