Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6235] - Fix undefined var for ReCapture 2.0 API calls.

? Success
Pull Request for # 6227

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Feb 2015

The Google ReCaptcha plugin supports 1.0 and 2.0 API calls.

Reuse of the getResponse() method is made use of for both API versions but 2.0 doesnt need/require the $challenge

This PR just silences strict warnings by setting the $challenge to `null and adds a tiny bit of additional documentation, cleans up a couple of other warnings and documents unused vars in method calls/signature

Closes #6227

avatar PhilETaylor PhilETaylor - open - 28 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Mar 2015
Rel_Number ⇒ 6227
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 1 Mar 2015
Category ⇒ Plugins
avatar PhilETaylor
PhilETaylor - comment - 1 Mar 2015

added spaces as requested

avatar leetempest
leetempest - comment - 2 Mar 2015

@test Tested with display errors on and all still works fine and no warnings/notices raised - captcha still works

avatar zero-24 zero-24 - alter_testresult - 2 Mar 2015 - leetempest: Tested successfully
avatar waader
waader - comment - 13 Mar 2015

@test works, thanks!

avatar waader waader - test_item - 13 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Mar 2015

Two tests setting RTC - Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6235.
avatar brianteeman brianteeman - change - 13 Mar 2015
Status Pending ⇒ Ready to Commit
avatar brianteeman brianteeman - change - 13 Mar 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 13 Mar 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-03-13 15:29:11
avatar wilsonge wilsonge - close - 13 Mar 2015
avatar wilsonge wilsonge - reference | - 13 Mar 15
avatar wilsonge wilsonge - merge - 13 Mar 2015
avatar wilsonge wilsonge - close - 13 Mar 2015
avatar zero-24 zero-24 - close - 13 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment