? Success
Referenced as Pull Request for: # 6298

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
25 Feb 2015

I just noticed today that the previous commit I submitted before caused some issue with the sub-menu dropdowns. The height was not adjusting accordingly, but have fixed that now.

#5913

avatar C-Lodder C-Lodder - open - 25 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 25 Feb 2015

Is this in any way connected to the report here #6174


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6190.
avatar C-Lodder
C-Lodder - comment - 25 Feb 2015

@brianteeman - yes, that will probably be it.

avatar zero-24 zero-24 - change - 26 Feb 2015
Category UI/UX
avatar hans2103
hans2103 - comment - 26 Feb 2015

Will test it tomorrow

avatar wilsonge
wilsonge - comment - 27 Feb 2015

@test unsuccessful. Clicking on a item then moving to another menu item seems to happen on hover as a result of this patch. Furthermore the original bug (that was fixed with #5913) is now back again

avatar C-Lodder
C-Lodder - comment - 27 Feb 2015

@wilsonge - Not to worry, fixed it. Will commit tomorrow.

Remove !important from the height which is inside the max-width: 767px media query

avatar brianteeman
brianteeman - comment - 27 Feb 2015

Note to testers: The cache on mobile browsers is VERY persistent so dont
forget to clear it manually

On 27 February 2015 at 09:19, Lodder notifications@github.com wrote:

@wilsonge https://github.com/wilsonge - Not to worry, fixed it. Will
commit tomorrow


Reply to this email directly or view it on GitHub
#6190 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar hans2103
hans2103 - comment - 27 Feb 2015

this issue related to #6174 . Closed that issue since this one provides a fix.

Patch succesfully tested on smartphone. Will test new code when committed.

avatar C-Lodder
C-Lodder - comment - 27 Feb 2015

updated PR

avatar hans2103
hans2103 - comment - 27 Feb 2015

@test unsuccessful on iPhone 5 with Chrome
@test successful on iPhone 5 with Safari

Using Safari the div for submenu enlarges giving me the ability to scroll down for all submenus
Using Chrome the div for submenu doesn't enlarge dynamicly. I'm not able to scroll for all submenus.

avatar C-Lodder
C-Lodder - comment - 28 Feb 2015

Thanks for the feedback @hans2103. I'll try and sort it for chrome over the weekend

avatar wilsonge
wilsonge - comment - 3 Mar 2015

@C-Lodder any updates on this?

avatar C-Lodder
C-Lodder - comment - 3 Mar 2015

@wilsonge not yet. I'm not sure if any changes were made to the menu as I have no yet compared it to the default Bootstrap one. This is just a weird one as it's not normal behavior for the Bootstrap menu.

avatar nonumber
nonumber - comment - 4 Mar 2015

I think the solution to this is not via css but html:
Just add the class collapsed to the btn-navbar link and collapse to the nav-collapse div.
See #6298

avatar nonumber nonumber - reference | - 4 Mar 15
avatar zero-24 zero-24 - change - 8 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-08 20:41:35
Closed_By zero-24
avatar joomla-cms-bot joomla-cms-bot - close - 8 Mar 2015
avatar zero-24
zero-24 - comment - 8 Mar 2015

Closing as we have @nonumber's PR that is successful tested and RTC now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6190.
avatar joomla-cms-bot
joomla-cms-bot - comment - 8 Mar 2015

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/6190

Add a Comment

Login with GitHub to post a comment