Login to Admin --> Articles
http://awesomescreenshot.com/0564hitm99
http://awesomescreenshot.com/0c64hijg15
MAC v 10.6.8
Firefox v 35.0.1
Chrome v 40.0.2214.111
CSS fix:
.j-sidebar-container {
margin: -2px 0 0 -1px;
}
That is correct Brian. I disabled the "Display Header" within the Template Manager for the ISIS admin template.
Found it
In template manager select styles and then Isis
In the advanced tabs scroll down to Display Header
You have the setting at No. Change it back to the default Yes
Looks like we posted at the same time ;)
I did a quick test of your change and it seems to be good in both scenarios
Since you seem to know where the issue is, can you create a Pull Request?
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests for how to do it. We can help you if you have questions.
This way it can be tested.
Status | New | ⇒ | Confirmed |
Category | Administration | ⇒ | Administration Templates (admin) |
Typically I disable that header. Perhaps only a handful do as well. No worries thanks Brian.
Labels |
Added:
?
|
Since you seem to know where the issue is, can you create a Pull Request?
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests for how to do it. We can help you if you have questions.
This way it can be tested.
Sorry Brian had to disconnect for a little and take care of something. I will create a pull request for this. Thx.
I don't think the best way to solve this is to change margin, which will not give a good design if header is enabled.
My question is : don't you think that if an option is supposed to hide the header (title + joomla logo) it is supposed to not display the title ?
Maybe it would be better to remove those line in index.php :
// Show the page title here if the header is hidden
if (!$displayHeader) : ?>
<h1 class="content-title"><?php echo JHtml::_('string.truncate', $app->JComponentTitle, 0, false, false); ?></h1>
<?php endif; ?>
@JoomliC I understand your point. I prefer the title to still be present, although a case could be made for removing it completely if the title+header option is disabled.
Okay submitted the pull request #6222
I think we can close here, as we have a PR in process : #6222
Thanks @ChristopherRaymond ! ;-)
@JoomliC @ChristopherRaymond I'm a little confused has this been resolved?
Status | Confirmed | ⇒ | Information Required |
@brianteeman Me too...
The issue reported is not solved, but the PR was opened and closed for one reason i didn't really understand (i think it was an error : #6222 (comment)), as @ChristopherRaymond was doing its best to understand how to use generatecss.php, and to finalize his PR with a minor padding-bottom fix (even if i think that if option is supposed to show/hide Header, i still wonder why the title is displayed if the header is set to Hide...).
Maybe wait a few days if @ChristopherRaymond want you to reopen PR #6222 and want to update the PR (two files changed to be reverted, and only one line to be added to Isis template.less before to process generatecss.php)...
My two-penn'orth : a logic and easy way to fix this issue is to remove code from index.php to display nothing when Header is set to Hide (we don't display a container, so seems logic to not display a part of its content, no ?) : #6222 (comment)
;-)
@JoomliC A few days have past, and no reply to this. Would you mind doing the PR so we can get this fixed? Thank you.
@roland-d Yes i can, but my proposal is to fix logic, to not display parts of content if its container is disabled : #6178 (comment)
I can do one or the other (removal or a bit more margin bottom if header disabled) but don't know what would be the accepted change (my proposal seems logical based on the option purpose : to hide all the header, and not keep parts of it. But if logic, then we miss the page title somewhere, and the current structure of the Isis template does not allow easy flexibility... :-|
@roland-d To be clear, to screenshots ;-)
Current issue, when Isis Option "Display Hearder" to on No
:
1. Removal of page title (but even if logic with option purpose, the page title will miss... so maybe not so good):
2. Keep page title, but additional styling for sidebar (and correct html placement of page title):
But in case 2 and current state: no space benefit to hide header...
So 1 or 2 , ;-)
@JoomliC Thank you for the clear explanation. I have tested the option and how it looks etc. Now I have a good understanding of the whole issue. Let's go with option 1 because option 2 makes no sense if you decide to hide the bar it shouldn't show up somewhere else. Thanks.
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-20 15:41:51 |
Closed_By | ⇒ | roland-d |
The problem appears to be that you have changed the admin template
See screenshot http://awesomescreenshot.com/0914hj3ucf
On 25 February 2015 at 14:47, ChristopherRaymond notifications@github.com
wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/