?
Referenced as Pull Request for: # 10563
avatar ChristopherRaymond
ChristopherRaymond
25 Feb 2015

Steps to reproduce the issue

Login to Admin --> Articles

Expected result

http://awesomescreenshot.com/0564hitm99

Actual result

http://awesomescreenshot.com/0c64hijg15

System information (as much as possible)

MAC v 10.6.8
Firefox v 35.0.1
Chrome v 40.0.2214.111

Additional comments

CSS fix:

.j-sidebar-container {
margin: -2px 0 0 -1px;
}

avatar ChristopherRaymond ChristopherRaymond - open - 25 Feb 2015
avatar brianteeman
brianteeman - comment - 25 Feb 2015

The problem appears to be that you have changed the admin template
See screenshot http://awesomescreenshot.com/0914hj3ucf

On 25 February 2015 at 14:47, ChristopherRaymond notifications@github.com
wrote:

Steps to reproduce the issue

Login to Admin --> Articles
Expected result

http://awesomescreenshot.com/0564hitm99
Actual result

http://awesomescreenshot.com/0c64hijg15
System information (as much as possible)

MAC v 10.6.8
Firefox v 35.0.1
Chrome v 40.0.2214.111
Additional comments

CSS fix:

.j-sidebar-container {
margin: -2px 0 0 -1px;
}


Reply to this email directly or view it on GitHub
#6178.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar ChristopherRaymond
ChristopherRaymond - comment - 25 Feb 2015

That is correct Brian. I disabled the "Display Header" within the Template Manager for the ISIS admin template.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar brianteeman
brianteeman - comment - 25 Feb 2015

Found it

In template manager select styles and then Isis
In the advanced tabs scroll down to Display Header
You have the setting at No. Change it back to the default Yes


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar brianteeman
brianteeman - comment - 25 Feb 2015

Looks like we posted at the same time ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar brianteeman
brianteeman - comment - 25 Feb 2015

I did a quick test of your change and it seems to be good in both scenarios

Since you seem to know where the issue is, can you create a Pull Request?
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests for how to do it. We can help you if you have questions.
This way it can be tested.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar brianteeman brianteeman - change - 25 Feb 2015
Status New Confirmed
avatar brianteeman brianteeman - change - 25 Feb 2015
Category Administration Administration Templates (admin)
avatar ChristopherRaymond
ChristopherRaymond - comment - 25 Feb 2015

Typically I disable that header. Perhaps only a handful do as well. No worries thanks Brian.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar brianteeman brianteeman - change - 25 Feb 2015
Labels Added: ?
avatar ChristopherRaymond
ChristopherRaymond - comment - 25 Feb 2015

Since you seem to know where the issue is, can you create a Pull Request?
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests for how to do it. We can help you if you have questions.
This way it can be tested.

Sorry Brian had to disconnect for a little and take care of something. I will create a pull request for this. Thx.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar JoomliC
JoomliC - comment - 26 Feb 2015

I don't think the best way to solve this is to change margin, which will not give a good design if header is enabled.

My question is : don't you think that if an option is supposed to hide the header (title + joomla logo) it is supposed to not display the title ?

Maybe it would be better to remove those line in index.php :

// Show the page title here if the header is hidden
if (!$displayHeader) : ?>
    <h1 class="content-title"><?php echo JHtml::_('string.truncate', $app->JComponentTitle, 0, false, false); ?></h1>
<?php endif; ?>


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar ChristopherRaymond
ChristopherRaymond - comment - 26 Feb 2015

@JoomliC I understand your point. I prefer the title to still be present, although a case could be made for removing it completely if the title+header option is disabled.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar ChristopherRaymond
ChristopherRaymond - comment - 27 Feb 2015

Okay submitted the pull request #6222


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar JoomliC
JoomliC - comment - 2 Mar 2015

I think we can close here, as we have a PR in process : #6222
Thanks @ChristopherRaymond ! ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.
avatar wilsonge wilsonge - reference | e8845db - 16 Jun 15
avatar brianteeman
brianteeman - comment - 11 Mar 2016

@JoomliC @ChristopherRaymond I'm a little confused has this been resolved?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.

avatar brianteeman brianteeman - change - 11 Mar 2016
Status Confirmed Information Required
avatar JoomliC
JoomliC - comment - 13 Mar 2016

@brianteeman Me too...
The issue reported is not solved, but the PR was opened and closed for one reason i didn't really understand (i think it was an error : #6222 (comment)), as @ChristopherRaymond was doing its best to understand how to use generatecss.php, and to finalize his PR with a minor padding-bottom fix (even if i think that if option is supposed to show/hide Header, i still wonder why the title is displayed if the header is set to Hide...).

Maybe wait a few days if @ChristopherRaymond want you to reopen PR #6222 and want to update the PR (two files changed to be reverted, and only one line to be added to Isis template.less before to process generatecss.php)...

My two-penn'orth : a logic and easy way to fix this issue is to remove code from index.php to display nothing when Header is set to Hide (we don't display a container, so seems logic to not display a part of its content, no ?) : #6222 (comment)
;-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.

avatar roland-d
roland-d - comment - 17 May 2016

@JoomliC A few days have past, and no reply to this. Would you mind doing the PR so we can get this fixed? Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.

avatar JoomliC
JoomliC - comment - 18 May 2016

@roland-d Yes i can, but my proposal is to fix logic, to not display parts of content if its container is disabled : #6178 (comment)

I can do one or the other (removal or a bit more margin bottom if header disabled) but don't know what would be the accepted change (my proposal seems logical based on the option purpose : to hide all the header, and not keep parts of it. But if logic, then we miss the page title somewhere, and the current structure of the Isis template does not allow easy flexibility... :-|

avatar JoomliC
JoomliC - comment - 18 May 2016

@roland-d To be clear, to screenshots ;-)

Current issue, when Isis Option "Display Hearder" to on No:
capture d ecran 2016-05-18 a 19 38 43

1. Removal of page title (but even if logic with option purpose, the page title will miss... so maybe not so good):
capture d ecran 2016-05-18 a 19 36 30

2. Keep page title, but additional styling for sidebar (and correct html placement of page title):
capture d ecran 2016-05-18 a 19 35 38
But in case 2 and current state: no space benefit to hide header...

So 1 or 2 , ;-)

avatar roland-d
roland-d - comment - 20 May 2016

@JoomliC Thank you for the clear explanation. I have tested the option and how it looks etc. Now I have a good understanding of the whole issue. Let's go with option 1 because option 2 makes no sense if you decide to hide the bar it shouldn't show up somewhere else. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6178.

avatar JoomliC
JoomliC - comment - 20 May 2016

This issue could be closed, as we have a new PR : #10563
;-)

And +1 with option 1 ????

avatar roland-d
roland-d - comment - 20 May 2016

Closing this in favor for #10563

avatar roland-d roland-d - change - 20 May 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-05-20 15:41:51
Closed_By roland-d
avatar roland-d roland-d - close - 20 May 2016

Add a Comment

Login with GitHub to post a comment