? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
23 Feb 2015

CodeMirror 5.0 is out and here it is. Please see http://codemirror.net/ for details. Basically, it might work on mobile now.

Also:

  • I'm minifying the mode files now which probably doesn't make that much difference but anyway...
  • Minified files are now *.min.js and *.min.css, uncompressed is *.js and *.css. Previously, the compressed version was simply *.js, *.css with uncompressed marked with '-uncompressed' which was kind of ugly.
avatar okonomiyaki3000 okonomiyaki3000 - open - 23 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 23 Feb 2015

The formatted name -uncompressed is specially used when debug is on. One should not get rid of it.

avatar dgt41
dgt41 - comment - 23 Feb 2015

@infograf768 I think @okonomiyaki3000 has covered nicely this option

$ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js';

same thing goes for css, so no real worries for dropping the -uncompressed

avatar infograf768
infograf768 - comment - 23 Feb 2015

Why would we? imho, better normalize.

avatar Fedik
Fedik - comment - 23 Feb 2015

JHtml::_('script') will detect automatically debug mode, for uncompressed and for .min.js

so this $ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js'; do no need, just enough JHtml::_('script', 'pathto/script.min.js')

avatar okonomiyaki3000
okonomiyaki3000 - comment - 23 Feb 2015

For some time now, JHtml::script and JHtml::stylesheet have been able to swap .min.js and .min.css for their non-min counterparts when debug is on. So you basically have the option to use the .min way or the -uncompressed way. I'm choosing .min because it just seems like the better way of doing it (and it's kind of a defacto standard anyway).

The line of code that @dgt41 mentions is not using JHtml::script so I'm choosing the extension in a more direct way but I intend to remove this in the near future anyway.

avatar zero-24 zero-24 - change - 24 Feb 2015
Easy No Yes
avatar zero-24 zero-24 - change - 26 Feb 2015
Category External Library
avatar brianteeman
brianteeman - comment - 5 Mar 2015

This needs to be testes and merged quickly as this fixes a major issue with CodeMirror in the template manager (you can't type / )


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.
avatar Fedik
Fedik - comment - 5 Mar 2015

test show that it works (also type / fixed)
but I see milestone 3.5 :smiley:

avatar Fedik Fedik - test_item - 5 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Mar 2015

yes the milestone was before the serious bug was discovered

On 5 March 2015 at 19:09, Fedir Zinchuk notifications@github.com wrote:

test show that it works
but I see milestone 3.5 [image: :smiley:]


Reply to this email directly or view it on GitHub
#6150 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar FrankyDE
FrankyDE - comment - 14 Mar 2015

Without patch:
tested on iPad front and back-end everything works, so I am not sure if I can actually test the patch.
tested on iPhone 6 works fine too.
Side-Note: Code Mirror does not generate closing tag "

" if you use Swipe as a (non standard) keyboard, default keyboard works fine.

After Patch: Everything seems to work correctly

Test MacBook Pro: Successful
Test iPad Air 2 Successful
Test iPhone 6 Successful

avatar brianteeman
brianteeman - comment - 14 Mar 2015

@frankyDE one easy test you can do is before the patch try to type a / it wont work. After the patch it will

avatar tecpromotion
tecpromotion - comment - 14 Mar 2015

Test successfully. Works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.
avatar tecpromotion tecpromotion - test_item - 14 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 14 Mar 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 14 Mar 2015

RTC based on testing! Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6150.
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar FrankyDE
FrankyDE - comment - 14 Mar 2015

thanks Brian, I tested that now without the patch and "/" does not display it simply vanishes.
Bug confirmed in iPad

Patch tested successful ! :-) #happy

avatar wilsonge wilsonge - change - 17 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-17 12:45:51
avatar wilsonge wilsonge - close - 17 Mar 2015
avatar wilsonge wilsonge - reference | - 17 Mar 15
avatar wilsonge wilsonge - merge - 17 Mar 2015
avatar wilsonge wilsonge - close - 17 Mar 2015

Add a Comment

Login with GitHub to post a comment