User tests: Successful: Unsuccessful:
CodeMirror 5.0 is out and here it is. Please see http://codemirror.net/ for details. Basically, it might work on mobile now.
Also:
Labels |
Added:
?
|
@infograf768 I think @okonomiyaki3000 has covered nicely this option
$ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js';
same thing goes for css, so no real worries for dropping the -uncompressed
Why would we? imho, better normalize.
JHtml::_('script')
will detect automatically debug mode, for uncompressed
and for .min.js
so this $ext = JFactory::getConfig()->get('debug') ? '.js' : '.min.js';
do no need, just enough JHtml::_('script', 'pathto/script.min.js')
For some time now, JHtml::script
and JHtml::stylesheet
have been able to swap .min.js
and .min.css
for their non-min counterparts when debug is on. So you basically have the option to use the .min way or the -uncompressed way. I'm choosing .min because it just seems like the better way of doing it (and it's kind of a defacto standard anyway).
The line of code that @dgt41 mentions is not using JHtml::script
so I'm choosing the extension in a more direct way but I intend to remove this in the near future anyway.
Easy | No | ⇒ | Yes |
Category | ⇒ | External Library |
This needs to be testes and merged quickly as this fixes a major issue with CodeMirror in the template manager (you can't type / )
test show that it works (also type / fixed)
but I see milestone 3.5
yes the milestone was before the serious bug was discovered
On 5 March 2015 at 19:09, Fedir Zinchuk notifications@github.com wrote:
test show that it works
but I see milestone 3.5 [image: ]—
Reply to this email directly or view it on GitHub
#6150 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Without patch:
tested on iPad front and back-end everything works, so I am not sure if I can actually test the patch.
tested on iPhone 6 works fine too.
Side-Note: Code Mirror does not generate closing tag "
After Patch: Everything seems to work correctly
Test MacBook Pro: Successful
Test iPad Air 2 Successful
Test iPhone 6 Successful
Test successfully. Works as expected.
Status | Pending | ⇒ | Ready to Commit |
RTC based on testing! Thanks!
Labels |
Added:
?
|
thanks Brian, I tested that now without the patch and "/" does not display it simply vanishes.
Bug confirmed in iPad
Patch tested successful ! :-) #happy
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-17 12:45:51 |
The formatted name -uncompressed is specially used when debug is on. One should not get rid of it.