[#6148] - Fix for issue #6042. Fix error message when phpinfo() is called.
- Closed
- 27 Feb 2015
- Medium
- Build: staging
- Easy Test
- # 6148
- Diff
- delftswa2014:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix error message when phpinfo() is called on server that disables this function
I added a function called phpinfo_enabled at sysinfo.php (administrator/components/com_admin/models/sysinfo.php) which check if phpinfo is enabled on server. If it is enabled then getPHPInfo will execute normaly otherwise an empty string will return with no warning.
joomla-cms-bot
- | Labels |
Added:
?
|
||
@brianteeman can you have a look into the new string?
@test success full with last commit. Thanks @pcmitsis
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6148.
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration Language & Strings UI/UX |
I have commented in line about the string. Both correcting the english of the string used and questioning if it is even the correct thing to say
@brianteeman should i change the string with a new commit with the one proposed?
should i change the string with a new commit with the one proposed?
@pcmitsis yes. Brian is a en-GB native speaker and the lead of the en-GB language file WG.
Thanks @brianteeman
Thank you @brianteeman and @zero-24 for your valuable help in this PR!
| Rel_Number | 0 | ⇒ | 6042 |
| Relation Type | ⇒ | Pull Request for |
@larsomator you are welcome!
@larsomator can you test @pcmitsis 's PR? So we can move this to RTC. (and maybe merge for 3.4.1 
)
if you need help for testing the com_patchtester will help you:
https://docs.joomla.org/Testing_Joomla!_patches
https://docs.joomla.org/Component_Patchtester_for_Testers
Thanks!
@Kubik-Rubik thank you very much for your notes! I already changed the and to &&.Would you like me to do anything else?
@Kubik-Rubik done! Travis CI build is in progress
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-27 22:19:05 |
| Milestone |
Added: |
||
@zero-24 I fixed them both. I wasn't sure about the version that's why i had 3.5 ! Sorry for the inconvenience.