Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6146] - Fix for PR #6131 (final)

? Success

User tests: Successful: Unsuccessful:

avatar pcmitsis
pcmitsis
22 Feb 2015

Final Fix for PR #6131 from @n9iels and issue #6126

I just found a little bug when changing a file with the editor in the template manager.
My Joomla! version is 3.4.0-rc

1. Go to Template Manager -> Templates and choose a template
2. Open a file and save it (you won't have to change anything).
3. Check the file permission of this file, you now see the changed from 644 to 444.

This can cause problems when editing the same file via a ftp client. You will get a "Permission denied" message
avatar pcmitsis pcmitsis - open - 22 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2015
Labels Added: ?
avatar pcmitsis
pcmitsis - comment - 22 Feb 2015

@infograf768 This is correct code. It doesn't have the issue that you mentioned in the earlier PR.

avatar infograf768
infograf768 - comment - 22 Feb 2015

Yep, I closed the other one
#6131 (comment)

avatar zero-24 zero-24 - change - 22 Feb 2015
Category ⇒ Administration Components
avatar zero-24 zero-24 - change - 22 Feb 2015
The description was changed
Easy No ⇒ Yes
avatar n9iels
n9iels - comment - 11 Mar 2015

@test Successful

I know this is originally my own PR, but with the CS changes it isn't anymore. Am I right? :grin:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6146.
avatar n9iels n9iels - test_item - 11 Mar 2015 - Tested successfully
avatar pcmitsis
pcmitsis - comment - 11 Mar 2015

@n9iels I didn't wanted to offend you! It was my first project collaboration at github and i didn't know the procedure to fix another PR. Of course i can close it and you can re open it !!

avatar n9iels
n9iels - comment - 11 Mar 2015

Ow no problems with that! glad you helped me :-)
The question was more: Am I allowed to test my own PR, know it is changed a little bit, so we can merge it.

Again: no problems with it, many thanks :-)

avatar pcmitsis
pcmitsis - comment - 11 Mar 2015

Thank you very much! Next time i am going to do a PR on your PR to fix such minors changes ( i learned the correct way now :smile: )

avatar yvesh yvesh - test_item - 14 Mar 2015 - Tested successfully
avatar yvesh
yvesh - comment - 14 Mar 2015

Okay patch seems to work just fine and not bringing new problems :smile: Any idea why that 444 change was in there?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6146.
avatar rmittl
rmittl - comment - 14 Mar 2015

Test is okay and works fine :-)

avatar brianteeman brianteeman - alter_testresult - 14 Mar 2015 - rmittl: Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Setting to RTC - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6146.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending ⇒ Ready to Commit
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar continga
continga - comment - 14 Mar 2015

Test is ok. No permissions changes to ti files.

avatar mbabker mbabker - reference | - 14 Mar 15
avatar mbabker mbabker - merge - 14 Mar 2015
avatar mbabker mbabker - close - 14 Mar 2015
avatar mbabker mbabker - change - 14 Mar 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-03-14 15:25:18
avatar mbabker mbabker - close - 14 Mar 2015
avatar tecpromotion tecpromotion - test_item - 14 Mar 2015 - Tested successfully

Add a Comment

Login with GitHub to post a comment