[#6134] - [imp] avoid to open div and closing it in different files
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6134
- Diff
- phproberto:devil-div
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In the catefories view the parent div was created in a layout. That's a bad practice that can cause unexpected issues when overriding views.
Test
Ensure that all the categories views are showed correctly. The PR includes articles, newsfeeds & contact categories because they were the only calling that layout but if you find more test it there please. Also in the menu item of each category view add a "Page class" in the "Page display" tab and ensure that is applied correctly.
Backward compatibility issues
This should only cause issues if someone is already using that layout. In that case they may have created a a dirty fix to close the orphan div. But this is a bug so we should fix it.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Layout |
| Category | Layout | ⇒ | Administration Layout |
designbengel
- 
Test OK
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing - RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6134.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 09:15:33 |
Merged. Thanks!
@test Success