[#6120] - Library adapter never sets itself to update
- Closed
- 19 Feb 2015
- Medium
- Build: staging
- # 6120
- Diff
- mbabker:libraryUpdate
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When updating libraries, the internal route never gets set to the update route so the installer always treats a library as a new install (which I guess is true in some ways since we actually uninstall the library completely then install it fresh). This changes the route to log it as an update when appropriate. This really only affects handling for extension install scripts and schema management.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
It's just never happened. Libraries have no internal handling of updates (heck, they just get uninstalled and installed as a new extension). At least this gives developers who are working with install scripts a chance to catch that it's an update that's happening.
Tested changes and they fix two issues for me:
- I am able to detect in my overridden JInstallerAdapterLibrary if it was install or update
- Library doesn't uninstall every second time as it did before this patch
Tested Installation of several extensions and templates and can confirm that the patch resolves issues for me too.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
Based on testing i will move this to RTC. And add it to the 3.4.0 milestone (on JTracker maybe someone with github access can sync?)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6120.
Patch resolves issues, consistently.
before patch applied - no library (3x tested)
after - library (3x tested)
reverted - no library (3x tested)
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-19 15:59:17 |
Thanks!
Is this a b/c thing as a result of the previous changes or a change in behaviour?