Cannot verify the fix as there's some other change in RC that broke installer on abort.

0 JLIB_INSTALLER_ABORT_INSTALL_CUSTOM_INSTALL_FAILURE

Is all I get, so it looks like there's exception which wasn't caught..?

The same behavior is seen with and without the patch and both with and without debug enabled.

Have any extension specifically to test with? I've mainly tested with my own extensions, Acymailing, and Kunena, and I've not hit that error at all.

Found the issue. Exceptions being thrown by the method triggering install scripts weren't being caught, causing the uncaught exception to hit the global error handler. Also traced down the fact that I completely missed adding that language string so it's added in here too.

Sent test files directly in skype. Will test it now.

Nice, confirmed fixing a few different issues:

• Missing translation string
• Debug mode now behaves in the same way as normal mode
• Installation was run even when preflight failed (modified Kunena installer failing on preflight)
• Installation was interrupted without displaying a reason (modified rokgallery failing on preflight)

Tested Installation of several of our extensions and templates and can confirm that the patch resolves issues for me too. We REALLY need this to go into J3.4 Stable or else we're in deep trouble!

Thanks for testing! Moving to RTC and add the 3.4.0 milestone (again only on JTracker)

@wilsonge This one needs to go in. Without it, any extension install scripts that return a false results in an uncaught exception bubbling up to the global handler. Granted, the original PR was for the debug check, but testing this found the exception issue.

@infograf768 please verify you're happy with these lang strings being added. Personally this isn't functionality that worked before 3.4 so I'm not gonna tear my hair out if we leave this till 3.4.1 (although it's not ideal)

Umm, actually the uncaught exception is a regression from 3.3...

@infograf768, @wilsonge

I would rather add those 2 new strings as currently (and in all versions down to J1.6) all users will see this very descriptive message instead:

JLIB_INSTALLER_ABORT_INSTALL_CUSTOM_INSTALL_FAILURE

So the language string has been there from Joomla 1.6... It was just never translated and everyone has seen the above key instead of anything that could be understood.

By not accepting this pull request you will cause major flood of support requests to many developers on subject: "Installation fails on JLIB_INSTALLER_ABORT_INSTALL_CUSTOM_INSTALL_FAILURE".

This is regression from Joomla 3.3 and NEEDS to be fixed.

JLIB_INSTALLER_ABORT_INSTALL_CUSTOM_INSTALL_FAILURE

Just to note, this string is actually new. It's based on 6 or 7 other strings (at a minimum) which all have single word differences and my language changes in the installer library have been an attempt at killing off an excess of language strings which only change the extension type or route.

Just tested J!2.5.28 and J!3.3.6 and both do have the translations. I know the translations were missing from some earlier version, but you're right, I do see:

Plugin Install: Custom install routine failure

Joomla 3.4.0-RC has no translation, though, and is showing up above key.

they are different strings.@mbabker is introducing a NEW string with this PR

JLIB_INSTALLER_ABORT_INSTALL_CUSTOM_INSTALL_FAILURE

The one you just mentioned is

JLIB_INSTALLER_ABORT_PLG_INSTALL_CUSTOM_INSTALL_FAILURE

NOTE the PLG

You're right, Brian.

The only thing is that new string already exists in RC. I'll PM you in Skype to allow you to test it out.

So the problem is that the string was added some time ago but it was never added to the language files

For the string, yes. Considering I added maybe 15-20 generalized strings
to try and replace ~75 needlessly duplicated strings, easy to miss one.

On Thursday, February 19, 2015, Brian Teeman notifications@github.com
wrote:

So the problem is that the string was added some time ago but it was never
added to the language files

—
Reply to this email directly or view it on GitHub
#6109 (comment).

So as this PR has been accepted and its a bug that the language string is
not in the language file this should be accepted. OF course it would be
better if it was translated but as we have other "error" messages that are
actually hard coded and in english by necessity I dont see a major issue

On 19 February 2015 at 18:06, Michael Babker notifications@github.com
wrote:

For the string, yes. Considering I added maybe 15-20 generalized strings
to try and replace ~75 needlessly duplicated strings, easy to miss one.

On Thursday, February 19, 2015, Brian Teeman notifications@github.com
wrote:

So the problem is that the string was added some time ago but it was
never
added to the language files

—
Reply to this email directly or view it on GitHub
#6109 (comment).

—
Reply to this email directly or view it on GitHub
#6109 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Folks, I can merge the 2 new strings separately from this PR and let TTs know about it today.
We do take into account this type of last minute new strings.
@mbabker
Shall I ?

Tested with rockfailure. OK for me.
Merging and letting TTs know.

Yes please JM if that is acceptable