Joomla! Issue Tracker | Joomla! CMS #6083 - CS

Closed
25 Feb 2015
Medium
Build: staging
Easy Test
# 6083
Diff
peterlose:cs-users

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

peterlose
13 Feb 2015

5cab367 13 Feb 2015

CS - forms in com_users

c42ce2c 13 Feb 2015

break

losedk - open - 13 Feb 2015

joomla-cms-bot - change - 13 Feb 2015

Labels

Added: ?

losedk - comment - 13 Feb 2015

Quick question. Are the fieldsets supposed to be on separate lines? This aren't really consistent at the moment

 <fieldset name="params" label="COM_USERS_SETTINGS_FIELDSET_LABEL">

<fieldset 
    name="params" 
    label="COM_USERS_SETTINGS_FIELDSET_LABEL">

zero-24 - change - 13 Feb 2015

Category

⇒

Code style

zero-24 - change - 13 Feb 2015

The description was changed

Status	Pending	⇒	Ready to Commit
Easy	No	⇒	Yes

zero-24 - comment - 13 Feb 2015

@losedk It is not exampled yet see: http://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md but i think it is ok to move it to one line.

Based on the comment:

When the element only has few attributes, then the whole element can stay on the same line. A max line length of 100 characters is recommended for good reading.

This PR will add it: joomla/coding-standards#95

Thanks for this PR I will move it to RTC.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6083.}

losedk - comment - 13 Feb 2015

@zero-24 Cool, thanks!

brianteeman - change - 15 Feb 2015

Labels

Added: ?

zero-24 - close - 25 Feb 2015

wilsonge - change - 25 Feb 2015

Status	Ready to Commit	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2015-02-25 00:54:27

wilsonge - close - 25 Feb 2015

zero-24 - change - 14 Oct 2015

Labels

Removed: ?

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#6083] - CS - Forms in com_users

Add a Comment