? Success
Pull Request for # 6077

User tests: Successful: Unsuccessful:

avatar sovainfo
sovainfo
13 Feb 2015

Fixes #6077
Without introducing yet another DIRECTORY_SEPARATOR !

avatar sovainfo sovainfo - open - 13 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 13 Feb 2015
Rel_Number 6077
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 13 Feb 2015
Category Libraries
avatar infograf768
infograf768 - comment - 14 Feb 2015

@test
This still works here on Macintosh. No idea on Windows.

avatar imanickam
imanickam - comment - 14 Feb 2015

I have tested this in a Windows 7 64 bit environment and it looks like there are still some issues. Following is the summary of the test results.

Scenario 1 - favicon.ico present in the template's folder: CORRECT
<link href="/joomla_34_b3/templates/protostar/favicon.ico" rel="shortcut icon" type="image/vnd.microsoft.icon" />

Scenario 2 - favicon.ico NOT present in the template's folder and favicon.ico NOT present in the site's root folder: CORRECT
No statement created for favicon.ico

Scenario 3 - favicon.ico NOT present in the template's folder and favicon.ico is present in the site's root directory: WRONG
<link href="/joomla_34_b3C:/wamp/www/joomla_34_b3/favicon.ico" rel="shortcut icon" type="image/vnd.microsoft.icon" />

For Scenario 3, the code generated is similar to the one that is generated before these changes.

Hope this helps.

avatar infograf768
infograf768 - comment - 14 Feb 2015

Correcting my test;
Indeed, if favicon in root: no show.
But then succeeds when reloading the page. Looks like it picks it now from the root of httpdocs when Joomla is in a folder.

avatar infograf768
infograf768 - comment - 14 Feb 2015

If I take off
//$path = JPath::clean($path, '/');
then it is OK here (Macintosh)

avatar imanickam
imanickam - comment - 14 Feb 2015

With the line (specified by infograf768) commented, all three scenarios wok fine.

avatar sovainfo
sovainfo - comment - 14 Feb 2015

@infograf768, @imanickam Thanks for testing. Below my Findings:
Findings:
Fuctionality: Provide a favicon in the browser. Active template overrides application.

Implementation: <link href="/j3x/j340b3/administrator/templates/isis/favicon.ico" rel="shortcut icon" type="image/vnd.microsoft.icon" />

Infra: W8.1 (32) XAMPP 1.8.1 (A: 2.4.3, M: 5.5.27, P: 5.4.7)

Environment: J336 on MySQL with Learning demo data

Result Favicon FE/BE Favicon location
:ok: V backend template
:ok: V backend administrator
:ok: X backend joomla root
:ok: X backend document root
:ok: V frontend template
:ok: V frontend joomla root
:ok: X frontend document root

Environment: J340b3 on MySQL with Learning demo data

Result Favicon FE/BE Favicon location
:x: X backend template
:ok: V backend administrator
:ok: X backend joomla root
:ok: X backend document root
:x: X frontend template
:ok: V frontend joomla root
:ok: X frontend document root

Environment: J340b3 on MySQL with Learning demo data
with PR manually applied

Result Favicon FE/BE Favicon location Comment
:ok: V backend template
:x: X backend administrator Filepath in url
:ok: X backend joomla root No icon link
:ok: X backend document root No icon link
:ok: V frontend template
:x: X frontend joomla root Filepath in url
:ok: X frontend document root No icon link

Environment:J340b3 on MySQL with Learning demo data
with PR manually applied, but reverted suggestion mbabker to use JPATH::clean

Result Favicon FE/BE Favicon location Comment
:ok: V backend template
:ok: V backend administrator
:ok: X backend joomla root No icon link
:ok: X backend document root No icon link
:ok: V frontend template
:ok: V frontend joomla root
:ok: X frontend document root No icon link

Based on these findings will revert the suggestion of mbabker to use JPATH::clean and request testing again.

avatar infograf768
infograf768 - comment - 15 Feb 2015

@test
Works on UNIX/Macintosh

avatar waader
waader - comment - 16 Feb 2015

@test works on windows! Thanks!

avatar waader waader - test_item - 16 Feb 2015 - Tested successfully
avatar infograf768 infograf768 - change - 17 Feb 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 17 Feb 2015

Merging. Thanks.

avatar infograf768 infograf768 - change - 17 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-17 04:29:01
avatar infograf768 infograf768 - close - 17 Feb 2015
avatar infograf768 infograf768 - reference | - 17 Feb 15
avatar infograf768 infograf768 - merge - 17 Feb 2015
avatar infograf768 infograf768 - close - 17 Feb 2015
avatar zero-24 zero-24 - close - 17 Feb 2015
avatar sovainfo
sovainfo - comment - 17 Feb 2015

Thank you all for testing and merging!

avatar sovainfo sovainfo - head_ref_deleted - 17 Feb 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment