? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Feb 2015

See http://forum.joomla.org/viewtopic.php?f=711&t=873043
The URL Language code (sef) for a content language in multilanguage is usually simple (and recommended to be). Example: fr in mysite.com/fr/something.

Some users may want to use a longer one. In the example from the forum above:
"nordsee-rerienhaus"

The database provides for it:
`sef varchar(50) NOT NULL,`

but the language.xml limits it to 7:

      <field name="sef" type="text"
         description="COM_LANGUAGES_FIELD_LANG_CODE_DESC"
         label="COM_LANGUAGES_FIELD_LANG_CODE_LABEL"
         maxlength="7"
         required="true"
         size="10"
      />

This PR changes the maxlength in the xml to the same as db.
To test, apply the PR and change for a content language the "Url Language Code" to something more than 7 characters.

avatar infograf768 infograf768 - open - 9 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2015
Labels Added: ?
avatar imanickam
imanickam - comment - 9 Feb 2015

I have tested this change and it works fine with having a ASCII string of more than Seven characters.

avatar infograf768
infograf768 - comment - 9 Feb 2015

I also added some code to make sure that the URL Language code is pure ascii and lowercase.
Please test again.

avatar imanickam
imanickam - comment - 9 Feb 2015

Tested again after the change to the file language.php and everything works fine. Entered several strings with Mixed Case and they are converted into lowercase. The characters such as single quote turns into dash. Spaces get removed.

avatar infograf768 infograf768 - change - 9 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 9 Feb 2015
avatar infograf768 infograf768 - change - 9 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-09 16:19:58
avatar infograf768 infograf768 - close - 9 Feb 2015
avatar infograf768 infograf768 - reference | - 9 Feb 15
avatar infograf768 infograf768 - merge - 9 Feb 2015
avatar infograf768 infograf768 - close - 9 Feb 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment