? ? ? Success
Referenced as Related to: # 7129

User tests: Successful: Unsuccessful:

avatar Radek-Suski
Radek-Suski
8 Feb 2015

Implementing a possibility to download system/environment information for support purposes.
The output is a text file which is probably not the best solution. Hope for some input.
It adds a button in "administrator/index.php?option=com_admin&view=sysinfo" which allows to create a text file with all relevant settings.
All sensitive informations should have been removed.

avatar Radek-Suski Radek-Suski - open - 8 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 8 Feb 2015

Awesome stuff. Can you alpha order the new language string please

avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

Sure. I will have to add some fixes to make Travis happy. Will try to fix it tomorrow.
But I think it can be already tested as it is as the functionality is provided.

avatar brianteeman
brianteeman - comment - 8 Feb 2015

In the file section the output is
administrator/components: administrator/components is writable
Shouldnt it be
administrator/components: is writable

Easier to read

avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

Yep. Thanks for the hint. Changing now

avatar brianteeman brianteeman - change - 8 Feb 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 8 Feb 2015
Labels Added: ?
avatar Radek-Suski Radek-Suski - reference | - 8 Feb 15
avatar Radek-Suski Radek-Suski - reference | - 8 Feb 15
avatar Radek-Suski Radek-Suski - reference | - 8 Feb 15
avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

Ok. I think I am done and Travis is happy. Thanks in advance for help.

avatar zero-24
zero-24 - comment - 8 Feb 2015

@Radek-Suski I have just open a PR that should fix CS errors :smile: Radek-Suski#1

Maybe you can have a look into the doc block lines with ... and fill the information there?

I will have a look into the next week!

Thanks a lot!

avatar Radek-Suski Radek-Suski - reference | - 8 Feb 15
avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

I just merged your request. Will take a look at the docblocks tomorrow.
It would be nice if someone could test it

avatar brianteeman
brianteeman - comment - 8 Feb 2015

It does what it says but do you think it is really needed or useful to output all of the phpinfo

Would it also be useful to add a list of ALL installed (non-core) extensions and their version numbers


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

@brianteeman I am not entirely sure if the entire PHP info is needed. It's the reason I asked for feedback.I was wondering about installed extensions as well. Not sure if it wouldn't be a huge informations disclosure.

avatar brianteeman
brianteeman - comment - 8 Feb 2015

If the generated file is only ever downloaded and not stored on the server
(which it is) then I dont see where the information disclosure would be. A
super user has full access to that information anyway

On 8 February 2015 at 21:52, Radek Suski notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I am not entirely sure if
the entire PHP info is needed. It's the reason I asked for feedback.I was
wondering about installed extensions as well. Not sure if it wouldn't be a
huge informations disclosure.


Reply to this email directly or view it on GitHub
#6021 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Radek-Suski
Radek-Suski - comment - 8 Feb 2015

I was thinking about people posting the file in some forums (it is the main purpose) and disclosing some (maybe) relevant information.
I am not sure however if this may be somehow critical.

avatar brianteeman
brianteeman - comment - 8 Feb 2015

Take a look at the information created by the FPA
https://github.com/ForumPostAssistant/FPA/

On 8 February 2015 at 22:06, Radek Suski notifications@github.com wrote:

I was thinking about people posting the file in some forums (it is the
main purpose) and disclosing some (maybe) relevant information.
I am not sure however if this may be somehow critical.


Reply to this email directly or view it on GitHub
#6021 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24 zero-24 - change - 8 Feb 2015
Easy No Yes
avatar zero-24 zero-24 - change - 9 Feb 2015
Category Administration
avatar zero-24 zero-24 - test_item - 9 Feb 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 9 Feb 2015

@Radek-Suski On testing all looks ok here. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar zero-24
zero-24 - comment - 9 Feb 2015

@Radek-Suski do you think we should add a text bevor the block like

=============
PhpSettings
=============
avatar Radek-Suski
Radek-Suski - comment - 15 Feb 2015

It depend if we want to have those settings included or not.
I agree with @brianteeman that a list of installed extensions may be more important.
Not sure though

avatar phproberto phproberto - reference | - 14 Mar 15
avatar phproberto
phproberto - comment - 14 Mar 2015

I have submitted a PR against your repo @Radek-Suski :
Radek-Suski#2

That will enable both JSON + TEXT export + move logic to models & views.

I can't wait to see all this information attached to the issues reported in github :+1:

avatar phproberto
phproberto - comment - 14 Mar 2015

It would be interesting to rebase your branch against latest staging. The staging sysinfo model has been changed so it can save us issues (I had to redo this patch 3 times to avoid causing conflicts with that).

avatar Businessfreunde Businessfreunde - test_item - 14 Mar 2015 - Tested successfully
avatar zurborg zurborg - test_item - 14 Mar 2015 - Tested successfully
avatar MAT978 MAT978 - test_item - 14 Mar 2015 - Tested successfully
avatar MAT978
MAT978 - comment - 14 Mar 2015

@test

works like a charm and fabulous improvement!

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar MAT978
MAT978 - comment - 14 Mar 2015

@phproberto

At this point, I'm not able to see the "download as text" option?
Maybe we have to wait @Radek-Suski to merge your PR?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar msdevcon
msdevcon - comment - 14 Mar 2015

@Test
works fine! thanks!

avatar Chalkin
Chalkin - comment - 14 Mar 2015

@test
Download of the file works fine! Information is available. Looks good!
Tested with Joomla 3.4.1-dev
Chrome 41.0.2272.89 MacOS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar Chalkin Chalkin - test_item - 14 Mar 2015 - Tested successfully
avatar ceus1984
ceus1984 - comment - 14 Mar 2015

Succsessfully tested


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Multiple good tests - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar Radek-Suski
Radek-Suski - comment - 14 Mar 2015

I want to add list of installed extensions into this. But I don't want to parse al XML files. Any idea for a better solution. I can't locate the right method in the com_installer. I can debug it through but if someone know the right place I would be thankful for an advice.

avatar brianteeman
brianteeman - comment - 14 Mar 2015

Why not query the _extensions table

avatar Radek-Suski
Radek-Suski - comment - 14 Mar 2015

It doesn't contain the version of the installed extension

avatar mbabker
mbabker - comment - 14 Mar 2015

The manifest_cache column has it, you'd have to json_decode it.

avatar Radek-Suski
Radek-Suski - comment - 14 Mar 2015

Ah. Cool. Thank @mbabker

avatar phproberto phproberto - change - 15 Mar 2015
Milestone Added:
avatar mbabker mbabker - change - 15 Mar 2015
Labels Removed: ?
avatar mbabker mbabker - change - 15 Mar 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2015
Labels Added: ?
avatar mbabker mbabker - change - 15 Mar 2015
Status Ready to Commit Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 15 Mar 2015

Reset to pending as another "feature" was added. Please re-test.

@Radek-Suski GitHub shows the branch can't be automatically merged, could you please merge the current staging branch in to your branch?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar mbabker mbabker - alter_testresult - 15 Mar 2015 - Businessfreunde: Not tested
avatar mbabker mbabker - alter_testresult - 15 Mar 2015 - Chalkin: Not tested
avatar mbabker mbabker - alter_testresult - 15 Mar 2015 - MAT978: Not tested
avatar mbabker mbabker - alter_testresult - 15 Mar 2015 - zero-24: Not tested
avatar mbabker mbabker - alter_testresult - 15 Mar 2015 - zurborg: Not tested
avatar mbabker mbabker - change - 15 Mar 2015
Labels Removed: ?
avatar mbabker mbabker - change - 15 Mar 2015
Labels Removed: ?
avatar MAT978
MAT978 - comment - 15 Mar 2015

What I was asking above ;)

@test

Both 'Download as JSON' and 'Download as text' work fine here with list of installed extensions.

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.
avatar MAT978 MAT978 - test_item - 15 Mar 2015 - Tested successfully
avatar sabindice
sabindice - comment - 10 Apr 2015

@test both download works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.

avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending Ready to Commit
avatar sabindice sabindice - test_item - 10 Apr 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 10 Apr 2015

Thanks for testing. Moving to RTC again :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6021.

avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 25 May 2015

Hey @Radek-Suski . Can you do things:
a) Fix the issue @roland-d mentioned about quoteName
b) Merge in staging so that I can get this awesome feature merged in!
Thanks!

avatar m-b-o m-b-o - test_item - 30 May 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 5 Jun 2015

Hey @Radek-Suski - Just a gentle reminder on this one now JAB is over :)

avatar phproberto phproberto - reference | 2f31392 - 5 Jun 15
avatar phproberto phproberto - reference | 28171a7 - 5 Jun 15
avatar phproberto phproberto - reference | 6166b8f - 5 Jun 15
avatar phproberto phproberto - reference | 1a10f5a - 5 Jun 15
avatar phproberto
phproberto - comment - 5 Jun 2015

I have created a new PR with this code rebased to be sure we don't have to deal with the sysinfo model conflicts: #7129

I have also applied @roland-d suggestion

avatar Radek-Suski
Radek-Suski - comment - 6 Jun 2015

@phproberto So you are taking over?

avatar phproberto
phproberto - comment - 6 Jun 2015

Sorry I thought it was ready to merge after adding the extensions list.

My PR just reorders the commits so the other core sysinfo patch is applied before yours and not conflicting anymore. Commits are the same.

I thought I was helping but I'll close my PR. If you need help ping me ;)

avatar Radek-Suski
Radek-Suski - comment - 6 Jun 2015

I am perfectly fine with you doing it Roberto. It wasn't an accusation, just a question :)

avatar phproberto
phproberto - comment - 6 Jun 2015

Ok :)

So let's close this and I'll reopen #7129

avatar wilsonge wilsonge - change - 6 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-06 18:36:13
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - close - 6 Jun 2015
avatar wilsonge wilsonge - close - 6 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Jun 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment