User tests: Successful: Unsuccessful:
Implementing a possibility to download system/environment information for support purposes.
The output is a text file which is probably not the best solution. Hope for some input.
It adds a button in "administrator/index.php?option=com_admin&view=sysinfo" which allows to create a text file with all relevant settings.
All sensitive informations should have been removed.
Labels |
Added:
?
|
Labels |
Added:
?
|
Sure. I will have to add some fixes to make Travis happy. Will try to fix it tomorrow.
But I think it can be already tested as it is as the functionality is provided.
In the file section the output is
administrator/components: administrator/components is writable
Shouldnt it be
administrator/components: is writable
Easier to read
Yep. Thanks for the hint. Changing now
Labels |
Added:
?
|
Labels |
Added:
?
|
Ok. I think I am done and Travis is happy. Thanks in advance for help.
@Radek-Suski I have just open a PR that should fix CS errors Radek-Suski#1
Maybe you can have a look into the doc block lines with ...
and fill the information there?
I will have a look into the next week!
Thanks a lot!
I just merged your request. Will take a look at the docblocks tomorrow.
It would be nice if someone could test it
It does what it says but do you think it is really needed or useful to output all of the phpinfo
Would it also be useful to add a list of ALL installed (non-core) extensions and their version numbers
@brianteeman I am not entirely sure if the entire PHP info is needed. It's the reason I asked for feedback.I was wondering about installed extensions as well. Not sure if it wouldn't be a huge informations disclosure.
If the generated file is only ever downloaded and not stored on the server
(which it is) then I dont see where the information disclosure would be. A
super user has full access to that information anyway
On 8 February 2015 at 21:52, Radek Suski notifications@github.com wrote:
@brianteeman https://github.com/brianteeman I am not entirely sure if
the entire PHP info is needed. It's the reason I asked for feedback.I was
wondering about installed extensions as well. Not sure if it wouldn't be a
huge informations disclosure.—
Reply to this email directly or view it on GitHub
#6021 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I was thinking about people posting the file in some forums (it is the main purpose) and disclosing some (maybe) relevant information.
I am not sure however if this may be somehow critical.
Take a look at the information created by the FPA
https://github.com/ForumPostAssistant/FPA/
On 8 February 2015 at 22:06, Radek Suski notifications@github.com wrote:
I was thinking about people posting the file in some forums (it is the
main purpose) and disclosing some (maybe) relevant information.
I am not sure however if this may be somehow critical.—
Reply to this email directly or view it on GitHub
#6021 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Easy | No | ⇒ | Yes |
Category | ⇒ | Administration |
@Radek-Suski On testing all looks ok here. Thanks!
@Radek-Suski do you think we should add a text bevor the block like
=============
PhpSettings
=============
It depend if we want to have those settings included or not.
I agree with @brianteeman that a list of installed extensions may be more important.
Not sure though
I have submitted a PR against your repo @Radek-Suski :
Radek-Suski#2
That will enable both JSON + TEXT export + move logic to models & views.
I can't wait to see all this information attached to the issues reported in github
It would be interesting to rebase your branch against latest staging. The staging sysinfo
model has been changed so it can save us issues (I had to redo this patch 3 times to avoid causing conflicts with that).
works like a charm and fabulous improvement!
thanks
At this point, I'm not able to see the "download as text" option?
Maybe we have to wait @Radek-Suski to merge your PR?
@test
Download of the file works fine! Information is available. Looks good!
Tested with Joomla 3.4.1-dev
Chrome 41.0.2272.89 MacOS
Succsessfully tested
Multiple good tests - setting RTC
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Labels |
Added:
?
|
I want to add list of installed extensions into this. But I don't want to parse al XML files. Any idea for a better solution. I can't locate the right method in the com_installer. I can debug it through but if someone know the right place I would be thankful for an advice.
Why not query the _extensions table
It doesn't contain the version of the installed extension
The manifest_cache column has it, you'd have to json_decode it.
Milestone |
Added: |
Labels |
Removed:
?
|
Labels |
Removed:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Pending |
Labels |
Added:
?
|
Reset to pending as another "feature" was added. Please re-test.
@Radek-Suski GitHub shows the branch can't be automatically merged, could you please merge the current staging branch in to your branch?
Labels |
Removed:
?
|
Labels |
Removed:
?
|
What I was asking above ;)
Both 'Download as JSON' and 'Download as text' work fine here with list of installed extensions.
Thanks
@test both download works
Status | Pending | ⇒ | Ready to Commit |
Thanks for testing. Moving to RTC again
Labels |
Added:
?
|
Labels |
Added:
?
|
Hey @Radek-Suski . Can you do things:
a) Fix the issue @roland-d mentioned about quoteName
b) Merge in staging so that I can get this awesome feature merged in!
Thanks!
Hey @Radek-Suski - Just a gentle reminder on this one now JAB is over :)
@phproberto So you are taking over?
Sorry I thought it was ready to merge after adding the extensions list.
My PR just reorders the commits so the other core sysinfo patch is applied before yours and not conflicting anymore. Commits are the same.
I thought I was helping but I'll close my PR. If you need help ping me ;)
I am perfectly fine with you doing it Roberto. It wasn't an accusation, just a question :)
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-06 18:36:13 |
Closed_By | ⇒ | wilsonge |
Labels |
Added:
?
|
Labels |
Added:
?
|
Milestone |
Removed: |
Labels |
Removed:
?
|
Awesome stuff. Can you alpha order the new language string please