? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 Feb 2015

Note: There are not any uses of this logger in the core CMS, so this one is either going to have to rely on unit tests & code review or I'll have to spend time writing an extension just to make this testable.

JLogLoggerCallback verifies that is has a callback and it is callable in its constructor and throws an exception if these conditions are not met. The problem here is that we do not have a JLogException exception, nor was the error condition unit tested. This PR addresses that.

avatar mbabker mbabker - open - 8 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Feb 2015
Category Libraries
avatar wilsonge wilsonge - close - 10 Feb 2015
avatar wilsonge wilsonge - reference | - 10 Feb 15
avatar wilsonge wilsonge - merge - 10 Feb 2015
avatar wilsonge wilsonge - close - 10 Feb 2015
avatar wilsonge wilsonge - change - 10 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-10 18:31:23
avatar wilsonge
wilsonge - comment - 10 Feb 2015

Merged on review

avatar wilsonge wilsonge - change - 10 Feb 2015
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 10 Feb 2015

Add a Comment

Login with GitHub to post a comment