?
avatar stellainformatica
stellainformatica
7 Feb 2015

Steps to reproduce the issue

Install a new language and set it for frontend. Login in frontend as superadmin and click on the edit button of the module "Latest Article"

Expected result

All strings should be translated

Actual result

Look at the bottom, the slide titles "Basic" and "Advanced" are not translated and activating the language debug you will see that there is not language definition for them.
The same for other types of modules, in Custom HTML module is not translated also the string "Options"

System information (as much as possible)

Joomla 3.4.0 beta2

Additional comments

avatar stellainformatica stellainformatica - open - 7 Feb 2015
avatar brianteeman
brianteeman - comment - 7 Feb 2015

Are you using a language for 3.4 or is it still a 3.3 language in your test

avatar infograf768
infograf768 - comment - 7 Feb 2015

Confirmed.
The issue is that these are hardcoded. Let's find where.

avatar stellainformatica
stellainformatica - comment - 7 Feb 2015

@brianteeman
I'm using a 3.4 language, they are not still released, but as italian TT we already have a language package to test
If you need the language attach it here (if it is allowed)

avatar brianteeman
brianteeman - comment - 7 Feb 2015

I found the problem and I am writing a patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6009.
avatar zero-24
zero-24 - comment - 7 Feb 2015

Oh sorry @brianteeman i don't see you comment. Ok you can open the PR :smile: Thanks

avatar brianteeman
brianteeman - comment - 7 Feb 2015

Please see #6010


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6009.
avatar brianteeman
brianteeman - comment - 7 Feb 2015

My PR is slightly different to your suggestion - please check

On 7 February 2015 at 12:18, zero-24 notifications@github.com wrote:

Oh sorry @brianteeman https://github.com/brianteeman i don't see you
comment. Ok you can open the PR [image: :smile:] Thanks


Reply to this email directly or view it on GitHub
#6009 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 7 Feb 2015

yes your patch is the correct one. sorry @brianteeman

avatar zero-24 zero-24 - close - 7 Feb 2015
avatar zero-24 zero-24 - change - 7 Feb 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-02-07 12:24:14
Closed_By zero-24
avatar joomla-cms-bot joomla-cms-bot - close - 7 Feb 2015
avatar joomla-cms-bot
joomla-cms-bot - comment - 7 Feb 2015

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/6009

avatar joomla-cms-bot joomla-cms-bot - close - 7 Feb 2015
avatar zero-24
zero-24 - comment - 7 Feb 2015

Thanks @brianteeman for the fix and @stellainformatica for the Tracker. Please have a look into Brians PR that fix the issue for me.

I'm closing here as we have Brians PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6009.
avatar brianteeman
brianteeman - comment - 7 Feb 2015

Woohoo my coding is improving

On 7 February 2015 at 12:22, zero-24 notifications@github.com wrote:

yes your patch is the correct one. sorry @brianteeman
https://github.com/brianteeman


Reply to this email directly or view it on GitHub
#6009 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768 infograf768 - reference | - 7 Feb 15
avatar stellainformatica
stellainformatica - comment - 8 Feb 2015

Patch tested, working fine. Thanks Brian.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6009.
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment