Feeling Lucky
?
[#6005] - Move one `JFactory::getUser();` call.
- Closed
- 7 Feb 2015
- Medium
- Build: staging
- Easy Test
- # 6005
- Diff
- zero-24:patch-10
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR fix a typo at the move one ContactModelContact andJFactory::getUser(); call.
Joomla-bugs reference
http://www.joomla-bugs.de/forum/index.php/topic,649.msg3050.html#new
joomla-cms-bot
- | Labels |
Added:
?
|
||
joomdonation
- comment
- 7 Feb 2015
The fix typo is wrong as George mentioned. However, the "move one JFactory::getUser(); call" is good and should be updated (how about calling return JFactory::getUser()->authorise('core.edit.state', 'com_contact.category.' . (int) $record->catid); directly ? )
zero-24
- comment
- 7 Feb 2015
hmm ok so i revert here and leave the moving of JFactory::getUser(); call. So this is a simple CS PR 
| Category | ⇒ | Code style |
| Title |
|
||||||
| Easy | No | ⇒ | Yes | ||||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-07 16:03:52 |
| Milestone |
Added: |
||
wilsonge
- comment
- 7 Feb 2015
Merged on review
This seems wrong? You're checking there is a valid contact id to delete. We have exactly the same check in all components (e.g. the one in com_content here https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L159)