[#5984] - Set a 500 header if we hit the 'Error display the error page' message
- Closed
- 5 Feb 2015
- Medium
- Build: staging
- Easy Test
- # 5984
- Diff
- mbabker:errorHeader
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In error conditions that cannot render the error template, we fall back to just echoing a message. However, it is possible that this message will send a HTTP 200 OK header. In reality, we should be sending an error header back. This PR will try to send a HTTP 500 error header if the headers have not already been sent.
Test Instructions
The easiest way to get here is to have your database server offline. Without the patch, you should get a HTTP 200 header when you see this message. Apply the patch and try the request again; a 500 header should be sent.
jissues-bot
- | Labels |
Added:
?
|
||
You can use Fiddler (http://www.telerik.com/fiddler) to inspect them. There are probably also easier tools.
If you're using Google Chrome, the dev tools will show the responses on the network tab. I think Firefox is similar.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
Merged. Thanks Michael!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-05 21:42:47 |
@mbabker have you any easy way to check the HTTP Header?