[#5979] - JFormRuleEquals doesnt take into account group
- Closed
- 16 Jul 2016
- Medium
- Build: staging
- # 5979
- Diff
- Devportobello:issue5965
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The rule equals doesnt take into account group fields so we cant validate this rule.
To reproduce the issue
Setup JForm XML form with a group + use field to validate equals:
ex:
<?xml version="1.0" encoding="utf-8"?>
<form>
<fields name="example">
<field name="name" type="text" ... />
<field name="password" type="password"
autocomplete="off"
class="validate-password"
description="DESIRED_PASSWORD"
field="password"
filter="raw"
label="PASSWORD_LABEL"
size="10"
validate="password"
required="true"
/>
<field name="password2" type="password"
autocomplete="off"
class="validate-password"
description="PASSWORD2_DESC"
field="password"
filter="raw"
label="PASSWORD2_LABEL"
message="PASSWORD1_MESSAGE"
size="30"
validate="equals"
required="true"
/>
</fields>
</form>OR use this custom component: https://github.com/Devportobello/joomla-attach-PR-5979
Expected result
Comparing password fields when password == password2 return true
Actual result
Comparing password fields dont return true if password == password2
System information
Joomla : Joomla! 3.4.1 Stable [ Ember ] 21-March-2015 20:30 GMT
PHP : 5.5.12
Apache : 2.4.9
Additional comments
Group are not taked into account when comparing value of those fields
Test instructions
- Download ZIP of com_test at https://github.com/Devportobello/joomla-attach-PR-5979
- Install it.
- Have a look into components/com_test/models/fields/test.xml if you want to.
- Go to frontend home. Add /?option=com_test to URL.
- Type "test" on all password field
- Submit form, you will see an error message about password2 not equals
- Apply patch
- Type "test" on all password field
- Submit form, you will see
string 'OK' (length=2)(used to exit code before save)
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
@test I followed the test instructions mentioned above and the patch worked.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5979.
I have tested this item 
successfully on a4f0cf1
I tested this according to the test instructions and tested the patch to be OK.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5979.
I have tested this item successfully on a4f0cf1
Succesfully tested the patch according to the test instructions
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5979.
I just ran into this issue and confirmed the proposed patch solved my problem. Can we get it merged?
| Status | Pending | ⇒ | Ready to Commit |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Any milestone for this ? :)
roland-d
- | Milestone |
Added: |
||
@joomla-cms-bot please help me here
| Status | Closed | ⇒ | Fixed in Code Base |
Can please someone with merge rights close this issue and remove the RTC label? It looks like the bot don't want to help me with this issue
| Status | New | ⇒ | Closed |
| Closed_Date | 2016-07-16 05:05:43 | ⇒ | 2016-07-16 12:14:23 |
| Closed_By | ⇒ | roland-d | |
| Labels | |||
Thanks.
Added a custom component "See description #5979 (comment)" to help test.