[#5972] - Redirect Manager : search broken. Removing required attribute from batch_urls textarea as it was breaking ...
- Closed
- 5 Feb 2015
- Medium
- Build: staging
- # 5972
- Diff
- thebeuving:issue5659
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
#5659
Since batch_urls (for batch updates) and the search function are all part of the same form having the required attribute on the batch_urls textarea was breaking search functionality. Removing the required attribute restore search. Someone could run a batch process without any content, but it will just give them an error on the redirects links page saying "No links added."
jissues-bot
- | Labels |
Added:
?
|
||
roland-d
- | Rel_Number | ⇒ | 5659 | |
| Relation Type | ⇒ | Pull Request for |
zero-24
- | Category | ⇒ | Administration Components |
@infograf768 See #3798
@Bakual
Understand. Therefore we should NOT be forced to choose an existing item to use the Batch button.
This has confused me as I thought it was related to the item(s) chosen.
As this Batch is in no way similar to the other Batch in core, we should also change the name of the button.
The issue comes from the fact that Redirect uses the default toolbar batch layout.
It's a batch function, just not the same as other batches. The name imho is fine.
But you're right that we don't need an item selected for it. However that's an issue unrelated to this PR 
However that's an issue unrelated to this PR
Sure, just noted.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-05 10:07:35 | ||||
@test
I can now search indeed.
TBH: I am not sure I understand what batch is supposed to do in this Manager