?
avatar peterlose
peterlose
4 Feb 2015

Sometimes I experience that the sidebar animation gets stuck on hover.

Please see the attached video:
https://www.dropbox.com/s/48qlqkmw2fij7kh/sidebar.mov?dl=0

avatar losedk losedk - open - 4 Feb 2015
avatar jissues-bot jissues-bot - change - 4 Feb 2015
Labels Added: ?
avatar jissues-bot jissues-bot - change - 4 Feb 2015
Labels Added: ?
avatar dgt41
dgt41 - comment - 4 Feb 2015

Confirmed, I ve seen this as well

avatar JoomliC
JoomliC - comment - 4 Feb 2015

I'm not able to reproduce this on beta2.
Are you able to have the same issue on beta2 or only on staging ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5970.
avatar dgt41
dgt41 - comment - 4 Feb 2015

@JoomliC This might be Safari 8 specific problem. Are you testing it with Safari?

avatar losedk
losedk - comment - 4 Feb 2015

I'm gonna test in some different browsers later tonight. This issue exist both in staging and in beta2

avatar JoomliC
JoomliC - comment - 4 Feb 2015

@dgt41 will test later on Safari 8 (my macbook has an older installed version).
Tested on Firefox, and no issue.
@losedk To be sure i understand how to reproduce the bug, is this one happens only when you click on "clear" button of the search input ?

avatar zero-24 zero-24 - change - 4 Feb 2015
Category Templates (admin) UI/UX
avatar losedk
losedk - comment - 6 Feb 2015

@JoomliC Nope, it happens when hovering the animation regardless of the action.

I think this is a Safari specific problem, I don't experience it in Firefox or Chrome (on mac)

avatar losedk
losedk - comment - 13 Feb 2015

Looked deeper into the problem, it origins from the collapse class in Isis index.php on line 204

<div class="subhead-collapse collapse">

I would recommend removing the class, as it seems to only effect Safari

avatar JoomliC
JoomliC - comment - 12 Mar 2015

@losedk do you have tested with this PR #6340 ?
Due to a few sidebar changes, it could maybe solve the issue in 3.4.0 ;-)

avatar losedk
losedk - comment - 12 Mar 2015

@JoomliC Just tested. It's the same:

skaermbillede 2015-03-12 kl 15 23 25

avatar JoomliC
JoomliC - comment - 13 Mar 2015

@losedk I was not able to reproduce exactly what you have on Safari 8, but i have a wrong animation of the sidebar (similar to your issue).
And it's true that if we remove the collapse, it's working fine :

<div class="subhead-collapse">

So, i wonder what for this "collapse" is, and if we could remove it... @dgt41 what's your opinion about this ? Should we create a PR to remove the "collapse" in subhead-collapse ?

avatar dgt41
dgt41 - comment - 13 Mar 2015

This collapse I think is the way to represent the toolbar as accordion for mobiles. If we remove it then the toolbar buttons will always be visible. Let me look at it later on when I will be at my desk...

avatar losedk
losedk - comment - 13 Mar 2015

Yeah, if removing the class the toolbar is always present

avatar JoomliC
JoomliC - comment - 13 Mar 2015

Thanks for this info @dgt41 !

avatar dgt41
dgt41 - comment - 15 Mar 2015

@JoomliC @losedk maybe you want to try this:
on isis/index.php insert

            $('.subhead-collapse').on('hidden', processScrollInit).on('shown', processScrollInit);

after line 283

See if that corrects the problem

avatar losedk
losedk - comment - 15 Mar 2015

@dgt41 doesn't fix the problem :/

skaermbillede 2015-03-15 kl 15 46 35

avatar dgt41
dgt41 - comment - 5 May 2015

@losedk @JoomliC Can you check that #6696 is solving this problem?

avatar losedk
losedk - comment - 6 May 2015

@dgt41 Just tested it. It doesn't solve the problem :/

skaermbillede 2015-05-06 kl 12 06 10

skaermbillede 2015-05-06 kl 12 06 50

avatar dgt41
dgt41 - comment - 6 May 2015

@losedk One more try:
with #6696 open template.js and paste:

                if (window.isisStickyToolbar == 1) {
                    processScrollInit();
                    processScroll();

                    $(window).on('resize', processScrollInit);
                    $(window).on('scroll', processScroll);
                }

after line 206 (after the } press return and the paste this snippet)
and after line 180 (same)
It should work, as it will re initiate the toolbar/header every time that the sidebar is evaluated!

avatar losedk
losedk - comment - 6 May 2015

@dgt41 I'm not getting the problem where the actual sidebar get's stuck, but I'm stil experiencing this:

skaermbillede 2015-05-06 kl 14 58 16

avatar dgt41
dgt41 - comment - 6 May 2015

@losedk but that is on a page without sidebar (single edit pages don’t have sidebar, right?)

avatar losedk
losedk - comment - 6 May 2015

@dgt41 yeah. But both problems origins from <div class="subhead-collapse collapse">

avatar dgt41
dgt41 - comment - 6 May 2015

@losedk in current staging if you remove the last <script> in index.php of isis, you should not get any problems, therefore this is the code that messes up the display. Sometimes it fires to early, (I think) and the final result is a mess…
Maybe we should re write that little thing there

avatar JoomliC
JoomliC - comment - 24 May 2015

@dgt41 Sorry for slow response...
As i'm not able to reproduce the issue both on imac or macbook, i can't tell you if #6696 is solving this issue, but i have applied this patch, and eveything is working fine!
Cyril

avatar dgt41
dgt41 - comment - 24 May 2015

@JoomliC Thanks, hope to see you @ JAB!

avatar losedk losedk - change - 24 Jun 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-06-24 17:51:15
Closed_By losedk
Build master staging
avatar losedk losedk - close - 24 Jun 2015

Add a Comment

Login with GitHub to post a comment