@rgmears can you send a PR for this change?
Category | ⇒ | Administration UI/UX |
Title |
|
||||||
Build | 3 | ⇒ | staging |
He is planning to - just trying to work out the way to do it with LESS etc
On 3 February 2015 at 16:08, zero-24 notifications@github.com wrote:
@rgmears https://github.com/rgmears can you send a PR for this change?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/5957
http://issues.joomla.org/tracker/joomla-cms/5957.—
Reply to this email directly or view it on GitHub
#5957 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Perhaps we could use the Bootstrap popover instead of the tooltip
That would work. My altered styling is similar to the popover. Contrary to what Brian said in the user-interface group I think the only file that needs changing is the tooltip.less (in the template folder) which, once compiled, will change the template.css. This would have to be done for both ISIS and HATHOR. Is that correct?
Except the a popover places content to the right while a tooltip places content above.
@dgt41 How would you like the tooltip to be different. Is my original suggestion (at the top) acceptable. My intention was to replace the tiny white text on black -- which is difficult to read -- with something more legible.
Labels |
Added:
?
|
How do I upload LESS and CSS files here?
You edit the LESS file and run https://github.com/joomla/joomla-cms/blob/staging/build/generatecss.php afterwards. That will regenerate the CSS files.
If you only use the GitHub UI, then you will not be able to run it.
If you work with a local branch, you run the generatecss.php file using php generatecss.php
(assuming PHP is set up to run from CLI like this).
Also it would be great if you could create one PR instead of the two. With the GitHub UI, you can go to one PR and see what branch it originates from, and the select that branch in your repo and navigate to the file you want to change. Edit that file while still having that branch active and it will automagically update your PR with the changes.
I am changing three files: two LESS files and then the generated CSS file. How do I do that in one pull request. And I do not know what you mean by running the generatecss.php file. How? I do not know how to use Command Line. Sorry. (Designer not programmer)
you will not be able to do that using the GitHub UI since you would need to run it locally from command line and then push it back using Git.
You can try to apply the changes manually, I think being a designer you know better than me how to create a CSS file from LESS. Just make sure you make your edits in the existing branch in your repo.
Follow that link to get to the patch-1
branch of your own fork: https://github.com/rgmears/joomla-cms/tree/patch-1
Everything you change in that branch, automatically becomes part of your PR #5982. So just edit the other two files within that branch.
I created three PRs, one for each file. The template.css file was (as were the others) copied from my local installation. I use a compiler called WinLess. (It's not the best but it works.) For whatever reason the template.css file did not get saved by GitHub. However, when I first saved it it did not record changes correctly.
There are now three patch files: rgmears-patch-1, patch-1, and patch-2. It would appear I should delete two of them. The first one — rgmears-patch-1 — appears to be the one you have linked to PR #5982. Is that correct?
Apologies. The template.css file was saved by GitHub. it is in rgmears-patch-1. How do I move the other two in to that PR?
You go to the branch and edit a file there while having that branch active. So go to https://github.com/rgmears/joomla-cms/tree/rgmears-patch-1 and navigate to
https://github.com/rgmears/joomla-cms/blob/rgmears-patch-1/administrator/templates/isis/less/template.less and https://github.com/rgmears/joomla-cms/blob/rgmears-patch-1/administrator/templates/isis/less/variables.less and click the edit button there.
Duh. Thanks Thomas. It's done.
Shall I delete the other two: patch-1 and patch-2 ?
Yes, please close the PRs and afterwards you can delete the branches.
Done.
How do we add the Pull Request to this thread?
You don't. Just create a new PR and cross link to this Issue.
So this doesn't count?
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-09 00:05:20 |
Closed_By | ⇒ | brianteeman |
Regardless the content, the text size should be increased. Or the colours switched. Tiny white text on a black background is difficult to read.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5957.