Feeling Lucky
?
[#5937] - Fix PHP errors in com_contact
- Closed
- 1 Feb 2015
- Medium
- Build: staging
- # 5937
- Diff
- wilsonge:contacterror
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fixes the issues described by @infograf768 in #5936
jissues-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 1 Feb 2015
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5937.
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-01 20:04:43 |
infograf768
- comment
- 2 Feb 2015
One thought:
Would it not have been better to keep catid in default_articles.php (to be consequent with the rest of core, and to add a `->select('a.catid')' in the model?
wilsonge
- comment
- 2 Feb 2015
if it works definitely! i just used the fix for that part you mentioned in the initial issue
infograf768
- comment
- 3 Feb 2015
I have tested it here and it works fine.
wilsonge
- comment
- 3 Feb 2015
Are you ok to make a PR then?
Works fine here. :)