? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
30 Jan 2015

With #4171 we introduced a new postinstall message about the changed htaccess.txt and web.config.txt files.
That PR added a language string which isn't needed because we don't have an action assigned to that message. Thus there is no button to press beside the default "Hide Message".

This PR removes that string so translators don't have to translate it.
Since the string is not yet in a stable release (only in alpha and beta) we can still remove it without any backward compatibility issues.

@infograf768 Agree?

avatar Bakual Bakual - open - 30 Jan 2015
avatar jissues-bot jissues-bot - change - 30 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 Jan 2015

As you are removing the code that would display the string it can not be an
issue even if it is translated

On 30 January 2015 at 14:39, Thomas Hunziker notifications@github.com
wrote:

With #4171 #4171 we introduced
a new postinstall message about the changed htaccess.txt and web.config.txt
files.
This PR added a language string which isn't needed because we don't have
an action assigned to that message. Thus there is no button to press beside
the default "Hide Message".

This PR removes that string so translators don't have to translate it.
Since the string is not yet in a stable release (only in alpha and beta)
we can still remove it without any backward compatibility issues.

@infograf768 https://github.com/infograf768 Agree?

You can view, comment on, or merge this pull request online at:

#5932
Commit Summary

  • Removing superfluous language string.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5932.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar rdeutz
rdeutz - comment - 30 Jan 2015

Looks good to me

avatar rdeutz rdeutz - close - 30 Jan 2015
avatar rdeutz rdeutz - reference | - 30 Jan 15
avatar rdeutz rdeutz - merge - 30 Jan 2015
avatar rdeutz rdeutz - close - 30 Jan 2015
avatar rdeutz rdeutz - change - 30 Jan 2015
The description was changed
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-30 18:34:30
avatar Bakual Bakual - head_ref_deleted - 30 Jan 2015
avatar waader
waader - comment - 30 Jan 2015

@test works for me - mysql, postgresql, mssql

avatar infograf768
infograf768 - comment - 31 Jan 2015

I found that issue when translating. Will let TTs know that string is no use anymore.

Add a Comment

Login with GitHub to post a comment