? Success
Related to # 5912

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
29 Jan 2015

In regards to the issue discussed here: #5912

avatar C-Lodder C-Lodder - open - 29 Jan 2015
avatar jissues-bot jissues-bot - change - 29 Jan 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 29 Jan 2015
Rel_Number 5912
Relation Type Related to
avatar brianteeman
brianteeman - comment - 29 Jan 2015

Did you delete the wrong repo?

avatar C-Lodder
C-Lodder - comment - 29 Jan 2015

@brianteeman - yeah, I ended up deleting and reforking when I got home. Does this cause any issues for the commit I made before?

avatar brianteeman
brianteeman - comment - 29 Jan 2015

I think you have deleted the wrong one. If you go to github it cannot fund
your code for this PR so it cannot be merged

avatar wilsonge
wilsonge - comment - 29 Jan 2015

It should be fine for merging (github shows a valid merge button anyhow) but if there are any issues with this pr you probably won't be able to update it and will have to make another new one.

avatar wilsonge
wilsonge - comment - 30 Jan 2015

@test replicated the initial menu issue and patch fixes it. One more tester

avatar wilsonge wilsonge - test_item - 30 Jan 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Jan 2015

I tested it originally before the LESS was added. As the LESS compiles (or
George couldnt have tested it correctly) I thik mine and all ther previous
tests should count and this can be merged

On 30 January 2015 at 21:51, George Wilson notifications@github.com wrote:

@test https://github.com/test replicated the initial menu issue and
patch fixes it. One more tester


Reply to this email directly or view it on GitHub
#5924 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24 zero-24 - alter_testresult - 30 Jan 2015 - brianteeman: Tested successfully
avatar zero-24 zero-24 - change - 30 Jan 2015
Category Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 30 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 30 Jan 2015

moving to RTC since we have two tests here Thanks to all here!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5924.
avatar brianteeman brianteeman - change - 30 Jan 2015
Labels Added: ?
avatar wilsonge wilsonge - close - 31 Jan 2015
avatar wilsonge wilsonge - reference | - 31 Jan 15
avatar wilsonge wilsonge - merge - 31 Jan 2015
avatar wilsonge wilsonge - close - 31 Jan 2015
avatar wilsonge wilsonge - change - 31 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-31 00:21:34
avatar wilsonge
wilsonge - comment - 31 Jan 2015

Merged. Thanks for your first PR @C-Lodder

Add a Comment

Login with GitHub to post a comment