?
Referenced as Pull Request for: # 6071
avatar Hils
Hils
29 Jan 2015

help-options

What is the correct order of the two buttons highlighted on the screenshot - Options Help.

Check these pages linked from the sidebar of Extension Manager:

Install [Help Option]
Update [Option Help]
Manage [Options Help]
Discover [Options Help]
Database [Help Options]
Warnings [Help Options]
Install Lang [Help Options]
Update sites [Options Help]

avatar Hils Hils - open - 29 Jan 2015
avatar jissues-bot jissues-bot - change - 29 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 29 Jan 2015

I would go with help- options
On 29 Jan 2015 10:30, "Hils" notifications@github.com wrote:

[image: help-options]
https://cloud.githubusercontent.com/assets/736887/5955981/955a3b4c-a7a0-11e4-8b72-0b17cfb03625.png

What is the correct order of the two buttons highlighted on the screenshot

  • Options Help.

Check these pages linked from the sidebar of Extension Manager:

Install [Help Option]
Update [Option Help]
Manage [Options Help]
Discover [Options Help]
Database [Help Options]
Warnings [Help Options]
Install Lang [Help Options]
Update sites [Options Help]


Reply to this email directly or view it on GitHub
#5921.

avatar brianteeman
brianteeman - comment - 29 Jan 2015

Having looked closer it appears that the standard everywhere is Help - Option

I will do a PR to standardise on this

Good fin @Hils Consistency Rocks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5921.
avatar Hils
Hils - comment - 29 Jan 2015

Thanks for checking Brian and thank you for doing the PR. I did actually just fork 3.4-dev to exercise my PR muscles but you will be far faster than me - cheers!

avatar Hils Hils - close - 29 Jan 2015
avatar Hils Hils - close - 29 Jan 2015
avatar Hils Hils - change - 29 Jan 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-01-29 11:09:17
avatar brianteeman brianteeman - change - 29 Jan 2015
Status Closed Confirmed
Closed_Date 2015-01-29 11:09:17
avatar brianteeman
brianteeman - comment - 29 Jan 2015

Sorry @hils I am going to have to re-open this one and leave the PR to someone else.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5921.
avatar brianteeman brianteeman - reopen - 29 Jan 2015
avatar brianteeman brianteeman - reopen - 29 Jan 2015
avatar Hils
Hils - comment - 29 Jan 2015

no problem. Has someone said they would do it or should I try and do it tomorrow?

avatar brianteeman
brianteeman - comment - 29 Jan 2015

Go for it

On 29 January 2015 at 12:04, Hils notifications@github.com wrote:

no problem. Has someone said they would do it or should I try and do it
tomorrow?


Reply to this email directly or view it on GitHub
#5921 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - change - 29 Jan 2015
Category Templates (admin) UI/UX
avatar Bakual
Bakual - comment - 29 Jan 2015

@hils Just shout if you need help :smile:

avatar Hils
Hils - comment - 29 Jan 2015

Thank you Thomas! It is my morning job tomorrow - will try my best :)

avatar zero-24
zero-24 - comment - 29 Jan 2015

@Hils

Just a tip

I did actually just fork 3.4-dev

Please send the PR against staging and not 3.4-dev as 3.4-dev is out of sync and the last changes are in the staging branche. :smile:

IIRC 3.4-dev is only not deleted to not autoclose the still open PRs against it.

avatar Hils
Hils - comment - 29 Jan 2015

Great tip and thanks for thinking! Will fork staging and delete my 3.4-dev fork in the morning :)

avatar brianteeman
brianteeman - comment - 12 Feb 2015

Please see #6071 for a solution


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5921.
avatar brianteeman brianteeman - change - 12 Feb 2015
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2015-02-12 21:57:43
Closed_By brianteeman
avatar brianteeman brianteeman - change - 12 Feb 2015
Closed_Date 2015-02-12 21:57:43 2015-02-12 21:57:50
avatar brianteeman brianteeman - close - 12 Feb 2015

Add a Comment

Login with GitHub to post a comment