?
Pull Request for # 5912

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
28 Jan 2015

see: #5912

On smaller devices, the mobile menu toggle seems to be acting oddly.

1st click = menu slide down
2nd click = menu slide up
3rd click = menu slide down
4th click = Nothing happens

No errors are appearing in the console log when it stops working.

Tested on Firefox (latest stable, developer and beta) and Chrome (latest).

mobile-menu

I've started trying to debug the issue and will submit a pull request if I find a solution

avatar C-Lodder C-Lodder - open - 28 Jan 2015
avatar jissues-bot jissues-bot - change - 28 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 28 Jan 2015
Category Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 28 Jan 2015
The description was changed
Rel_Number 5912
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 28 Jan 2015
Easy No Yes
avatar C-Lodder
C-Lodder - comment - 28 Jan 2015

@zero-24 - My bad, completely forgot about the less file. PR has been updated :)

avatar brianteeman
brianteeman - comment - 28 Jan 2015

@test works for me - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5913.
avatar brianteeman brianteeman - test_item - 28 Jan 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jan 2015

Correction - this breaks the desktop

http://i.tee.mn/6juh.png


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5913.
avatar brianteeman brianteeman - test_item - 28 Jan 2015 - Tested unsuccessfully
avatar C-Lodder
C-Lodder - comment - 28 Jan 2015

@brianteeman - Re-fixed this for larger screens. Now the height: auto is only applied to screen widths >= 768. Not sure what on earth is up with the styling for your filter when it should be on the left hand side but I don't get that at all.

avatar zero-24
zero-24 - comment - 28 Jan 2015

@C-Lodder github see some merge conflicts can you have a look into it?

avatar C-Lodder
C-Lodder - comment - 28 Jan 2015

@zero-24 - I was not able to see any conflicts until I tried merging my mobile-menu branch with my staging branch. I've fixed the conflict so shall I submit a PR from my staging branch? Sorry about the confusion, I'm not used to PR's and merging.

avatar zero-24
zero-24 - comment - 28 Jan 2015

@C-Lodder i think the easiest would be to do a new PR. But maybe someone with more git fu than me can help you to fix the conflicts.

avatar C-Lodder
C-Lodder - comment - 28 Jan 2015

@zero-24 - Not to worry. I will submit a new PR tomorrow morning and reference it in this conversation if need be

avatar zero-24
zero-24 - comment - 28 Jan 2015

:+1: Thanks!

avatar brianteeman
brianteeman - comment - 29 Jan 2015

Closed see #5924


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5913.
avatar brianteeman brianteeman - change - 29 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-29 15:33:13
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 Jan 2015
avatar brianteeman brianteeman - close - 29 Jan 2015

Add a Comment

Login with GitHub to post a comment